Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add Novu bridge#50414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromwouter-toppy:notifier-novu
Jun 16, 2023
Merged

Conversation

@wouter-toppy
Copy link
Contributor

@wouter-toppywouter-toppy commentedMay 24, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#50412
LicenseMIT
Doc PRsymfony/symfony-docs#18345

ProvideNovu integration for Symfony Notifier.

welcoMattic reacted with heart emojiSwahjak reacted with rocket emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@wouter-toppywouter-toppyforce-pushed thenotifier-novu branch 5 times, most recently from914e2fc tobf65025CompareMay 24, 2023 11:38
@welcoMattic
Copy link
Member

Hi@wouter-toppy! Thanks for your first contribution. As 6.3 is in feature-freeze, could you open your PR against 6.4 branch please? Thanks

wouter-toppy reacted with thumbs up emoji

@wouter-toppy
Copy link
ContributorAuthor

Hi@wouter-toppy! Thanks for your first contribution. As 6.3 is in feature-freeze, could you open your PR against 6.4 branch please? Thanks

Done

@wouter-toppy
Copy link
ContributorAuthor

@welcoMattic pipeline is still failing, but I cant see if that is a problem at my side.
tested the component, and it should be ready for merge to 6.4

@OskarStarkOskarStark changed the title[Notifier] Add Novu Notifier Bridge[Notifier] Add Novu bridgeMay 24, 2023
@OskarStarkOskarStark modified the milestones:6.3,6.4May 24, 2023
wouter-toppy added a commit to wouter-toppy/symfony that referenced this pull requestMay 25, 2023
wouter-toppy added a commit to wouter-toppy/symfony that referenced this pull requestMay 26, 2023
@lyrixxlyrixx removed their request for reviewMay 26, 2023 09:39
@wouter-toppy
Copy link
ContributorAuthor

@OskarStark anything i need to do to get this merged?

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please extendUnsupportedSchemeException andUnsupportedSchemeException, thanks

wouter-toppy reacted with thumbs up emoji
wouter-toppy added a commit to wouter-toppy/symfony that referenced this pull requestJun 15, 2023
wouter-toppy added a commit to wouter-toppy/symfony that referenced this pull requestJun 15, 2023
wouter-toppy added a commit to wouter-toppy/symfony that referenced this pull requestJun 15, 2023
@OskarStark
Copy link
Contributor

One last thing, can you please open a PR againstsymfony/recipes ? Thanks

wouter-toppy reacted with thumbs up emoji

@wouter-toppy
Copy link
ContributorAuthor

One last thing, can you please open a PR againstsymfony/recipes ? Thanks

@OskarStarksymfony/recipes#1214

@fabpot
Copy link
Member

Thank you@wouter-toppy.

WoutervanderLoopNL reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

@dunglasdunglasAwaiting requested review from dunglas

@ycerutoycerutoAwaiting requested review from yceruto

@kbondkbondAwaiting requested review from kbond

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasr

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

[Notifier] Implement Novu notifier

5 participants

@wouter-toppy@carsonbot@welcoMattic@OskarStark@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp