Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel][VarDumper] Fix dumping with labels#50397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.3fromnicolas-grekas:dump-fix
May 25, 2023

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Shouldfix#50347 (comment) /cc@bobthecow

Also improves the display in the WDT:

image

image

@carsonbotcarsonbot added this to the6.3 milestoneMay 23, 2023
@carsonbotcarsonbot changed the title[VarDumper][HttpKernel] Fix dumping with labels[HttpKernel][VarDumper] Fix dumping with labelsMay 23, 2023
@nicolas-grekasnicolas-grekas added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelMay 23, 2023
@bobthecow
Copy link
Contributor

Thanks for jumping on this,@nicolas-grekas!

This fix works, in that it no longer breaks functionality. But it does look like it introduces a change in formatted output that puts empty spans in front of a lot of things:

Screenshot 2023-05-23 at 10 19 29 AM

Either that or this was introduced somewhere else but masked by the BC break in my tests.

@nicolas-grekasnicolas-grekas removed the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelMay 23, 2023
@nicolas-grekasnicolas-grekas changed the base branch from6.4 to6.3May 23, 2023 16:47
@nicolas-grekas
Copy link
MemberAuthor

@bobthecow fixed!

@nicolas-grekasnicolas-grekas merged commit2f3e24a intosymfony:6.3May 25, 2023
@nicolas-grekasnicolas-grekas deleted the dump-fix branchMay 25, 2023 13:15
@bobthecow
Copy link
Contributor

@nicolas-grekas perfect, thanks so much!

@fabpotfabpot mentioned this pull requestMay 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

+1 more reviewer

@fancywebfancywebfancyweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@bobthecow@stof@fancyweb@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp