Won't this break CSP rules?

It doesn't appear to.

Thank you@PhilETaylor.

The right markup for this would be a<button type="button"> (with the appropriate CSS to make it look like a textual link). A<a> without href is neither interactive nor focusable, so this would be an accessibility issue.

@nicolas-grekas there is no CSP at all on profiler pages (our toolbar has to avoid CSP issues as it gets injected into the project pages)

The right markup for this would be a

I did type that out, but deleted it, sorry, was in the car earlier. I guess we need to revert this one, or revert it with a new PR, where would the css go?

As a button, with no css, it also doesn't have a pointer.

Markup:
line <button type="button" data-toggle-selector="#sf-trace-{{ loop.index0 }}">{{ caller.line }}</button> (<button type="button" data-toggle-selector="#sf-context-{{ loop.index0 }}">context</button>):

With new css inprofiler.css.twig

.sf-toggle-button {    background: none!important;    border: none;    padding: 0!important;    color: rgb(29, 78, 216);    cursor: pointer;}

Looks like this - if this is ok I can PR this:

ok?

converted to a button in PR#50386