Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[AssetMapper] Fix bug where dependencies were preloaded even if the parent was not#50356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

weaverryan
Copy link
Member

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsNone
LicenseMIT
Doc PRStill TODO

Inimportmap.php, if you havepreload => false for an assets... but that asset imports another assets, we would always list that imported asset as "preload => true". Basically, when looking at a dependency to determine if it should be preloaded, we need to first look at the parent to see if IT was preloaded.

Cheers!

@weaverryanweaverryanforce-pushed theasset-mapper-fix-preload-dependencies branch frombe67a07 to65dd360CompareMay 19, 2023 10:18
@nicolas-grekasnicolas-grekasforce-pushed theasset-mapper-fix-preload-dependencies branch from65dd360 tofeb680bCompareMay 19, 2023 11:59
@nicolas-grekas
Copy link
Member

Thank you@weaverryan.

@nicolas-grekasnicolas-grekas merged commit54a3b84 intosymfony:6.3May 19, 2023
@weaverryanweaverryan deleted the asset-mapper-fix-preload-dependencies branchMay 19, 2023 17:41
@fabpotfabpot mentioned this pull requestMay 22, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

3 participants
@weaverryan@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp