Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] Allow using enums in container configurator#50330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ludekbenedik wants to merge1 commit intosymfony:5.4fromludekbenedik:ticket_50275

Conversation

@ludekbenedik
Copy link

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#50275
LicenseMIT
Doc PR

[DependencyInjection] Allow using enums in container configurator

returnstaticfunction (ContainerConfigurator$configurator):void {$configurator->services()->set(MyService::class)        ->arg('$myEnum', MyEnum::First)    ;};

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Thanks but this has already been merged as a new feature in#48045
You need to upgrade to 6.2+

@ludekbenedik
Copy link
Author

Hi,

I know but versions 6.2 and 6.3 are not LTS. A new LTS will be minimal six months later. And then not all project will be updated immediately.

  1. The Symfony 5.4 LTS will be maintained to 2025
  2. It is allowedDefinition::setArgument(0, MyEnum::Foo) but notServiceConfigurator::arg(0, MyEnum::Foo)
  3. Enums can be injected via!php/const ... in YAML but cannot be injected via PHP File Configurator. PHP File Configurator is preferred and all Symfony configurations are in PHP files
  4. If a programmer wants to use PHP File Configurator and services uses enums then a part of configuration must be defined inKernel::configureContainer orExtension::load

Why this simple fix/feature cannot be merged to Symfony 5.4 LTS?

@stof
Copy link
Member

Well, if you want the latest feature, you should not stay on the LTS. the LTS version only receives bug fixes (as it only receives semver patch releases, not new minor versions)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@ludekbenedik@carsonbot@nicolas-grekas@stof

[8]ページ先頭

©2009-2025 Movatter.jp