Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (seehttps://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
• Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Merging in 6.3 as this is not a bug fix, but mainly an improvement.

Thank you@ivanpepelko.

I think the main issue was a bug on line 167:

return (int) $diff * 100 / $v;

should have been

return (int) ($diff * 100 / $v);

$diff was always less between 0.0 and 1.0, so would always (int) to 0, or 1.

My contribution feels a bit redundant given that they've moved on and refactored a while back, but might help someone wondering why getSaturation doesn't return anything useful.