Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Handle datetime deserialization in U format#50251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tugmaks
Copy link
Contributor

@tugmakstugmaks commentedMay 6, 2023•
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#50236
LicenseMIT
Doc PR-

Fixes#50236

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@tugmakstugmaks changed the titleHandle datetime deserialization in U format[Serializer] Handle datetime deserialization in U formatMay 6, 2023
@OskarStarkOskarStark requested a review fromstofMay 7, 2023 09:54
@tugmakstugmaksforce-pushed thedatetime-denormalize-u-format branch from1bd2cd2 to3e87d75CompareMay 10, 2023 14:56
@carsonbotcarsonbot changed the title[Serializer] Handle datetime deserialization in U formatHandle datetime deserialization in U formatMay 12, 2023
@carsonbotcarsonbot changed the titleHandle datetime deserialization in U format[Serializer] Handle datetime deserialization in U formatMay 12, 2023
@nicolas-grekasnicolas-grekasforce-pushed thedatetime-denormalize-u-format branch from803bcf8 to8149ee9CompareMay 12, 2023 08:29
@nicolas-grekasnicolas-grekas changed the base branch from6.2 to5.4May 12, 2023 08:35
@nicolas-grekasnicolas-grekasforce-pushed thedatetime-denormalize-u-format branch from8149ee9 to11d05adCompareMay 12, 2023 08:35
@nicolas-grekasnicolas-grekas modified the milestones:6.2,5.4May 12, 2023
@nicolas-grekasnicolas-grekasforce-pushed thedatetime-denormalize-u-format branch from11d05ad toa5d1ca6CompareMay 12, 2023 08:37
@nicolas-grekas
Copy link
Member

Thank you@tugmaks.

@nicolas-grekasnicolas-grekas merged commit2caaddc intosymfony:5.4May 12, 2023
@tugmaks
Copy link
ContributorAuthor

Thank you@tugmaks.

Thank you too!

@fabpotfabpot mentioned this pull requestMay 13, 2023
This was referencedMay 27, 2023
@tugmakstugmaks deleted the datetime-denormalize-u-format branchSeptember 27, 2024 13:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@stofstofAwaiting requested review from stof

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasr

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@tugmaks@carsonbot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp