NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpClient] Fix getting through proxies via CONNECT#50235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:hc-proxy

May 5, 2023

Merged

[HttpClient] Fix getting through proxies via CONNECT#50235

nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:hc-proxy

May 5, 2023

Conversation

Copy link

Member

nicolas-grekas commentedMay 4, 2023

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Spotted while trying to hit google viasymfony proxy:start:

https_proxy=http://127.0.0.1:7080 php test.php

where test.php contains:

$client =newCurlHttpClient();$r =$client->request('GET','https://google.com/');dump($r->getStatusCode());dump($r->getHeaders());dump($r->getInfo('debug'));

carsonbot added Status: Needs Review Bug HttpClient labels

May 4, 2023

carsonbot added this to the5.4 milestone

May 4, 2023

[HttpClient] Fix getting through proxies via CONNECT

78eff39

nicolas-grekas force-pushed thehc-proxy branch from666c50a to78eff39Compare

May 4, 2023 15:48

Copy link

Member

stof commentedMay 4, 2023

is there any way to have a test covering this to prevent regressions ?

Copy link

MemberAuthor

nicolas-grekas commentedMay 5, 2023

I won't be able to add a test covering that because it requires an HTTPS endpoint. Of course we could add some network services, but that's going to be too time consuming to setup properly...