Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[AssetMapper] Fixing 2 bugs related to the compile command and importmaps#50231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@weaverryan
Copy link
Member

@weaverryanweaverryan commentedMay 3, 2023
edited
Loading

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?none
Ticketsnone
LicenseMIT
Doc PRnot needed

Fixes 2 bugs:

A) Runningassetmap:compile gives you apublic/assets/importmap.json for fast importmap dumping on production. But, runningassetmap:compile again later would re-use theimportmap.json info to create the newimportmap.json... meaning it would never update after the first compile.

B) The importmap process generates 2 pieces of information: (A) the importmap and (B) which files from the importmap should be preloaded. When we useassetmap:compile, we need to dump both pieces of info. So, we now also dump animportmap.preload.json file. These are TWO files (and not just one) because we avoid parsingimportmap.json at runtime: we read the file and dump it straight out. We DO need to parse the "preload" file. So, I've kept them separate.

Blocked by#50219, which has some changes that will fix the tests here.

Cheers!

@fabpot
Copy link
Member

@weaverryan Can you rebase this PR now that#50219 is merged?

@nicolas-grekas
Copy link
Member

(rebase needed)

@weaverryanweaverryanforce-pushed theasset-mapper-compile-fixes branch frombd3c42d to329b413CompareMay 5, 2023 16:53
@weaverryan
Copy link
MemberAuthor

Good to go now - thanks for the merges!

@nicolas-grekasnicolas-grekasforce-pushed theasset-mapper-compile-fixes branch from329b413 tof9f7274CompareMay 5, 2023 23:11
@nicolas-grekas
Copy link
Member

Thank you@weaverryan.

weaverryan reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commitba94e95 intosymfony:6.3May 5, 2023
@weaverryanweaverryan deleted the asset-mapper-compile-fixes branchMay 6, 2023 00:10
@fabpotfabpot mentioned this pull requestMay 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

5 participants

@weaverryan@fabpot@nicolas-grekas@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp