Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Mime] Add PGP feature#50222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Mime] Add PGP feature#50222
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMay 3, 2023
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a great new feature. IMO it should be a new component:symfony/mime is independent of these new classes and it would make it easier to resolve dependencies withpear/crypt_gpg.
| @@ -17,6 +17,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=8.1", | |||
| "pear/crypt_gpg": "^1.6", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This needs to be moved torequire-dev as said inprevious comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Haven't I moved it to require-dev ind5b9214?
I'm glad you like the idea of that feature. A new component would be essential a standalone package under a certain namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Haven't I moved it to require-dev ind5b9214?
The commit sorts packages alphabetically, but does not move the package torequire-dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, I did that too. But it is actually underrequire-dev now:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
d5b9214 fixes thecomposer.json in the root dir, this issrc/Symfony/Component/Mime/composer.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I see. If it should't live insymfony/mime then it should be entirely removed from there and instead moved into a new component (for examplesymfony/pgp) where the dependency is handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hey,
the last months I tested my implementation in a Symfony app and discovered several flaws. For example it doesn't work with templated emails and sending via mail provider via api is also not possible due to the nature of a PGP structured mail.
I still would like to see that feature in Symfony and I'll work on that in the upcoming weeks.
@the-pulli Are you still willing to work on this? I agree with the previous comment that it should be part of a new component that would be well integrated with Mime. |
Sure@fabpot , I can give it another shot. My mentioned package from#50160 still working well for me in a Laravel app. But I discovered that most of the transactional mail provider doesn't support PGP encryption. The ones working for me were Mailtrap.io and ZohoMail. I keep you posted with updates and it's nice to know that there's still a demand for this feature. |
Is it really necessary to use
I am also interested in this feature. I can make myself available to help integrate it |
Closing in favor of#59372 |
As discussed in#50160 here is the corresponding PR.