Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] Remove legacy filters remnants#50214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@MatTheCat
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

#42195 introduced new filters for the WebProfilerBundle but it still contains some remnants, for example in the translation panel:

Uncaught TypeError: Sfjs.createFilters is not a function

This PR removes them all.

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 thanks Mathieu!

The ideal solution would be to recreate these filters in the new system instead of just removing the old filters which no longer work.

I've added this to my TODO list to see if I can do it for Symfony 6.4/7.0.

Thanks!

@nicolas-grekas
Copy link
Member

Thank you@MatTheCat.

@nicolas-grekasnicolas-grekas merged commitd3092c7 intosymfony:5.4May 5, 2023
@MatTheCatMatTheCat deleted the clean-filters-remnants branchMay 5, 2023 15:51
@MatTheCat
Copy link
ContributorAuthor

@javiereguiluz yes having the new filters everywhere (on the exception page as well; see#50213) would be nice!

@nicolas-grekas
Copy link
Member

I merged this up to 6.3

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@MatTheCat@nicolas-grekas@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp