Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Forward_stateless attribute to inline rendered fragments#50198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.3fromMatTheCat:stateless-fragments
May 2, 2023

Conversation

@MatTheCat
Copy link
Contributor

@MatTheCatMatTheCat commentedApr 30, 2023•
edited
Loading

QA
Branch?6.3
Bug fix?no
New feature?yes
Deprecations?no
TicketsPrerequisite for#50037
LicenseMIT
Doc PRN/A

For now inline rendered fragments have no mean of checking ifthe_stateless attribute has been set so they cannot adapt accordingly. This PR would allow them not to use the session if$request->attributes->getBoolean('_stateless') is true.

This could be used inProfilerController’ssearchBarAction eg.

@stofstof added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelMay 2, 2023
@stof
Copy link
Member

stof commentedMay 2, 2023

could you add a test covering this behavior to prevent regressions ?

@MatTheCatMatTheCatforce-pushed thestateless-fragments branch 2 times, most recently from61389e3 to725c105CompareMay 2, 2023 15:11
@MatTheCat
Copy link
ContributorAuthor

@stof done. I simplified the code as well.

@nicolas-grekas
Copy link
Member

Thank you@MatTheCat.

@nicolas-grekasnicolas-grekas merged commit5ea3bed intosymfony:6.3May 2, 2023
@MatTheCatMatTheCat deleted the stateless-fragments branchMay 2, 2023 16:22
fabpot added a commit that referenced this pull requestMay 5, 2023
This PR was merged into the 6.3 branch.Discussion----------Profiler respect stateless attribute| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#50037| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Now that#50198 forward `_stateless` attribute in fragments, this PR check this attribute and make profiler stateless when is required.I don't know which tests I have to add because session is not checked. (I checked on reproducer and it's ok)Commits-------7820776 [WebProfilerBundle] Profiler respect stateless attribute
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof approved these changes

+1 more reviewer

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

FeatureHttpKernel❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

5 participants

@MatTheCat@stof@nicolas-grekas@maxhelias@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp