NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Notifier] Added redlink notifier#50170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.4fromplotkabytes:redlink-notifier

Jun 21, 2023

Merged

[Notifier] Added redlink notifier#50170

fabpot merged 1 commit intosymfony:6.4fromplotkabytes:redlink-notifier

Jun 21, 2023

Conversation

Copy link

Contributor

plotkabytes commentedApr 27, 2023•
edited
Loading

Q	A
Branch?	6.3
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets
License	MIT
Doc PR	symfony/symfony-docs#18263

AddedRedlink notifier bridge

plotkabytes requested a review fromOskarStark as acode owner

April 27, 2023 09:15

carsonbot added Status: Needs Review Feature labels

Apr 27, 2023

carsonbot added this to the6.3 milestone

Apr 27, 2023

Copy link

carsonbot commentedApr 27, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

plotkabytes force-pushed theredlink-notifier branch from5e46f19 to032a4d5Compare

April 27, 2023 09:18

plotkabytes closed this

Apr 27, 2023

OskarStark reviewed

Apr 27, 2023

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Redlink/README.md Outdated


		where:

		- `API_TOKEN` is your user API token, you can get it from user dashboard

Copy link

Contributor

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	-`API_TOKEN` is your user API token, you can get it from user dashboard
	-`API_TOKEN` is your user API token, you can get it fromtheuser dashboard

src/Symfony/Component/Notifier/Bridge/Redlink/RedlinkTransport.php Outdated

		protected const HOST = 'api.redlink.pl';

		public function __construct(
		#[\SensitiveParameter] private readonly string $apiToken,

Copy link

Contributor

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	#[\SensitiveParameter]privatereadonly string$apiToken,
	#[\SensitiveParameter]
	privatereadonly string$apiToken,

src/Symfony/Component/Notifier/Bridge/Redlink/RedlinkTransport.php Outdated


		public function __construct(
		#[\SensitiveParameter] private readonly string $apiToken,
		#[\SensitiveParameter] private readonly string $appToken,

Copy link

Contributor

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	#[\SensitiveParameter]privatereadonly string$appToken,
	#[\SensitiveParameter]
	privatereadonly string$appToken,

src/Symfony/Component/Notifier/Bridge/Redlink/RedlinkTransport.php Outdated

		{
		return sprintf(
		'redlink://%s:%s@%s?from=%s&version=%s',
		$this->apiToken,

Copy link

Contributor

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should not be exposed

src/Symfony/Component/Notifier/Bridge/Redlink/RedlinkTransport.php Outdated

		return sprintf(
		'redlink://%s:%s@%s?from=%s&version=%s',
		$this->apiToken,
		$this->appToken,

Copy link

Contributor

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should not be exposed

src/Symfony/Component/Notifier/Bridge/Redlink/composer.json Outdated

		"require": {
		"php": ">=8.1",
		"symfony/http-client": "^5.4\|^6.0",
		"symfony/notifier": "^6.2.7"

Copy link

Contributor

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	"symfony/notifier":"^6.2.7"
	"symfony/notifier":"^6.3"

Copy link

Contributor

OskarStark commentedApr 27, 2023

Can you please open a PR on the Symfony docs and the symfony/recipes repository? Thanks

Copy link

Contributor

OskarStark commentedApr 27, 2023

Why did you close the PR?

plotkabytes reopened this

Apr 27, 2023

Copy link

ContributorAuthor

plotkabytes commentedApr 27, 2023

Why did you close the PR?

Sorry, this was by mistake. I made suggested changes, and I will open PR on the Symfony docs and the symfony/recipes repository soon. Thanks!

plotkabytes mentioned this pull request

Apr 27, 2023

Add Redlink docssymfony/symfony-docs#18263

Merged

Copy link

ContributorAuthor

plotkabytes commentedApr 27, 2023

Done.
recipes:symfony/recipes#1193
docs:symfony/symfony-docs#18263

Can you please open a PR on the Symfony docs and the symfony/recipes repository? Thanks

nicolas-grekas modified the milestones:6.3,6.4

May 23, 2023

fabpot approved these changes

Jun 21, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 21, 2023

fabpot added the Notifier label

Jun 21, 2023

carsonbot changed the title~~Added redlink notifier~~[Notifier] Added redlink notifier

Jun 21, 2023

Added redlink notifier

e0bd368

fabpot force-pushed theredlink-notifier branch from60197d4 toe0bd368Compare

June 21, 2023 06:37

Copy link

Member

fabpot commentedJun 21, 2023

Thank you@plotkabytes.

fabpot merged commitbad7e38 intosymfony:6.4

Jun 21, 2023

OskarStark added a commit to symfony/symfony-docs that referenced this pull request

Jun 21, 2023

feature#18263Add Redlink docs (plotkabytes)

585754c

This PR was submitted for the 6.3 branch but it was squashed and merged into the 6.4 branch instead.Discussion----------Add Redlink docsDocumentation for new redlink notifier. PR: [symfony/symfony#50170](symfony/symfony#50170).Commits-------9b9cd36 Add Redlink docs

This was referencedOct 21, 2023

Release v6.4.0-BETA1#52220

Merged

Release v7.0.0-BETA1#52224

Merged

Labels

Feature Notifier Status: Reviewed

Movatterモバイル変換

Uh oh!

[Notifier] Added redlink notifier#50170

[Notifier] Added redlink notifier#50170

Uh oh!

Conversation

plotkabytes commentedApr 27, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

carsonbot commentedApr 27, 2023

Uh oh!

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

Uh oh!

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

Uh oh!

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

Uh oh!

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

Uh oh!

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

Uh oh!

OskarStarkApr 27, 2023

Choose a reason for hiding this comment

Uh oh!

OskarStark commentedApr 27, 2023

Uh oh!

OskarStark commentedApr 27, 2023

Uh oh!

plotkabytes commentedApr 27, 2023

Uh oh!

plotkabytes commentedApr 27, 2023

Uh oh!

fabpot commentedJun 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

plotkabytes commentedApr 27, 2023•
edited
Loading