Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow sending scheduled messages through the slack API#50141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@RobinDeCroock
Copy link

QA
Branch?6.3
Bug fix?no
New feature?yes
Deprecations?no
Tickets/
LicenseMIT
Doc PRTODO

Add option post_at to the Slack Notifier bridge, this allows for easy scheduling of Slack messages.

valtzu reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekasnicolas-grekas modified the milestones:6.3,6.4May 23, 2023

if ($optsinstanceof UpdateMessageSlackOptions) {
$apiMethod ='chat.update';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The change above should be reverted as it's not related to the PR.

@fabpot
Copy link
Member

Thank you@RobinDeCroock.

@fabpotfabpotforce-pushed thenotifier-slack-scheduled-messages branch from8354f60 toa3a7d7aCompareOctober 1, 2023 16:44
@fabpotfabpot merged commite459f34 intosymfony:6.4Oct 1, 2023
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@RobinDeCroock@carsonbot@fabpot@nicolas-grekas@Insanfly

[8]ページ先頭

©2009-2025 Movatter.jp