Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] [SpotHit] Supportsmslong andsmslongnbr API parameters#50136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@camillebaronnet
Copy link
Contributor

@camillebaronnetcamillebaronnet commentedApr 24, 2023
edited by OskarStark
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT
Doc PRmandatory for components ?

By default, SMS via Spot Hit are strictly limited to 160 characters maximum. This PR allows to forward the corresponding arguments from the DSN to the API request to unlock this capability

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[Notifier][SpotHit] Support SMSLong and SMSLongNBr API parameters[Notifier] [SpotHit] Support SMSLong and SMSLongNBr API parametersApr 24, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@camillebaronnetcamillebaronnet changed the title[Notifier] [SpotHit] Support SMSLong and SMSLongNBr API parameters[Notifier] [SpotHit] Supportsmslong and `smslongnbr API parametersApr 24, 2023
@camillebaronnetcamillebaronnet changed the title[Notifier] [SpotHit] Supportsmslong and `smslongnbr API parameters[Notifier] [SpotHit] Supportsmslong andsmslongnbr API parametersApr 24, 2023
@camillebaronnet
Copy link
ContributorAuthor

wow sorry, the rebase notified everyone

@OskarStark
Copy link
Contributor

wow sorry, the rebase notified everyone

don't worry 😃

camillebaronnet reacted with heart emoji

@OskarStarkOskarStark changed the title[Notifier] [SpotHit] Supportsmslong andsmslongnbr API parameters[Notifier][SpotHit] Supportsmslong andsmslongnbr API parametersApr 25, 2023
@nicolas-grekasnicolas-grekas modified the milestones:6.3,6.4May 23, 2023
@carsonbotcarsonbot changed the title[Notifier][SpotHit] Supportsmslong andsmslongnbr API parameters[Notifier] [SpotHit] Supportsmslong andsmslongnbr API parametersJul 9, 2023
@fabpotfabpotforce-pushed thefeat/spothit-api-arguments branch fromcafc9bc to95091a1CompareJuly 30, 2023 13:19
@fabpot
Copy link
Member

Thank you@camillebaronnet.

camillebaronnet reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

@lyrixxlyrixxAwaiting requested review from lyrixx

@kbondkbondAwaiting requested review from kbond

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasr

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@camillebaronnet@carsonbot@OskarStark@fabpot@nicolas-grekas

[8]ページ先頭

©2009-2025 Movatter.jp