Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] [SpotHit] Supportsmslong andsmslongnbr API parameters#50136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedApr 24, 2023
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedApr 24, 2023
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features". Cheers! Carsonbot |
smslong and `smslongnbr API parameterssmslong and `smslongnbr API parameterssmslong andsmslongnbr API parametersUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/SpotHit/SpotHitTransportFactory.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/SpotHit/Tests/SpotHitTransportTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
24e8408 tobc5e80dComparecamillebaronnet commentedApr 25, 2023
wow sorry, the rebase notified everyone |
OskarStark commentedApr 25, 2023
don't worry 😃 |
bc5e80d to0f389c4Comparesmslong andsmslongnbr API parameterssmslong andsmslongnbr API parameterssrc/Symfony/Component/Notifier/Bridge/SpotHit/SpotHitTransport.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
smslong andsmslongnbr API parameterssmslong andsmslongnbr API parameters0f389c4 tod010668Comparecafc9bc to95091a1Comparefabpot commentedJul 30, 2023
Thank you@camillebaronnet. |
Uh oh!
There was an error while loading.Please reload this page.
By default, SMS via Spot Hit are strictly limited to 160 characters maximum. This PR allows to forward the corresponding arguments from the DSN to the API request to unlock this capability