NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Notifier] add Ntfy bridge#50131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.4frommikaelkael:ntfy-notification

Jun 20, 2023

Merged

[Notifier] add Ntfy bridge#50131

fabpot merged 1 commit intosymfony:6.4frommikaelkael:ntfy-notification

Jun 20, 2023

Conversation

Copy link

Contributor

mikaelkael commentedApr 23, 2023•
edited by OskarStark
Loading

Q	A
Branch?	6.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets
License	MIT
Doc PR	symfony/symfony-docs#18253
Recipes PR	symfony/recipes#1204

AddNtfy notifier bridge

mikaelkael requested a review fromOskarStark as acode owner

April 23, 2023 22:21

carsonbot added Status: Needs Review Feature Notifier labels

Apr 23, 2023

carsonbot added this to the6.3 milestone

Apr 23, 2023

Copy link

carsonbot commentedApr 23, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

OskarStark reviewed

Apr 24, 2023

View reviewed changes

Copy link

Contributor

OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the new bridge 👍🏻

src/Symfony/Component/Notifier/Bridge/Ntfy/NtfyOptions.phpShow resolvedHide resolved

src/Symfony/Component/Notifier/Bridge/Ntfy/NtfyOptions.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Notifier/Bridge/Ntfy/NtfyTransport.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Notifier/Bridge/Ntfy/NtfyTransportFactory.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Notifier/Bridge/Ntfy/Tests/NtfyOptionsTest.phpShow resolvedHide resolved

mikaelkael force-pushed thentfy-notification branch from7cc6d29 to108e9b4Compare

April 24, 2023 15:16

Copy link

ContributorAuthor

mikaelkael commentedApr 24, 2023•
edited
Loading

@OskarStark : I exploded the modifications in 4 commits based on comments. Hope that's help for the review. Thanks!

In addition, a commit for the docs is ready (mikaelkael/symfony-docs@9507b06)

Copy link

Contributor

OskarStark commentedApr 25, 2023

Can please create a PR for the Symfony docs from your commit? Thanks

mikaelkael mentioned this pull request

Apr 25, 2023

[Notifier] Add Ntfy bridgesymfony/symfony-docs#18253

Merged

Copy link

ContributorAuthor

mikaelkael commentedApr 25, 2023

Can please create a PR for the Symfony docs from your commit? Thanks

@OskarStark : it's done bysymfony/symfony-docs#18253

OskarStark reviewed

Apr 25, 2023

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Ntfy/README.md OutdatedShow resolvedHide resolved

OskarStark reviewed

Apr 25, 2023

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Ntfy/README.md OutdatedShow resolvedHide resolved

OskarStark reviewed

Apr 25, 2023

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Ntfy/README.md OutdatedShow resolvedHide resolved

OskarStark reviewed

Apr 25, 2023

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Ntfy/composer.json OutdatedShow resolvedHide resolved

OskarStark requested a review fromfabpot

April 25, 2023 06:49

Copy link

Contributor

OskarStark commentedApr 26, 2023

@fabpot this looks ready to merge from my side 👍

Copy link

Member

fabpot commentedApr 26, 2023

That will be for 6.4.

mikaelkael added a commit to mikaelkael/ntfy-notifier that referenced this pull request

Apr 29, 2023

Apply same changes as in PR for 6.4 (symfony/symfony#50131)

aefb365

nicolas-grekas modified the milestones:6.3,6.4

May 23, 2023

mikaelkael force-pushed thentfy-notification branch fromc0aea01 to000dcf6Compare

May 27, 2023 16:48

Copy link

Contributor

OskarStark commentedMay 27, 2023

Please add a PR tosymfony/recipes repository, thanks

mikaelkael mentioned this pull request

May 29, 2023

[Notifier] add Ntfy notifiersymfony/recipes#1204

Merged

Copy link

Member

fabpot commentedJun 16, 2023

Now that the 6.4 branch is available,@mikaelkael can you rebase this PR so that we can merge it? Thank you.

mikaelkael force-pushed thentfy-notification branch from000dcf6 to757bc73Compare

June 16, 2023 16:09

Copy link

ContributorAuthor

mikaelkael commentedJun 16, 2023

Now that the 6.4 branch is available,@mikaelkael can you rebase this PR so that we can merge it? Thank you.

I did it 3 weeks ago but it was broken with the Novu integration few minutes ago. I rebased the 3 PR (code, docs and recipes) 😊

OskarStark changed the title~~[Notifier] add Ntfy Notifier Bridge~~[Notifier] add Ntfy bridge

Jun 17, 2023

OskarStark approved these changes

Jun 19, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 19, 2023

fabpot approved these changes

Jun 20, 2023

View reviewed changes

[Notifier] add Ntfy bridge

c097511

fabpot force-pushed thentfy-notification branch from757bc73 toc097511Compare

June 20, 2023 10:27

Copy link

Member

fabpot commentedJun 20, 2023

Thank you@mikaelkael.

fabpot merged commitb51e2d3 intosymfony:6.4

Jun 20, 2023

mikaelkael deleted the ntfy-notification branch

June 20, 2023 16:47

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request

Jul 4, 2023

minor#18253[Notifier] Add Ntfy bridge (mikaelkael)

55a46e7

This PR was squashed before being merged into the 6.4 branch.Discussion----------[Notifier] Add Ntfy bridgeIn addition withsymfony/symfony#50131 for the new Ntfy notifier bridgeCommits-------79d6e73 [Notifier] Add Ntfy bridge

This was referencedOct 21, 2023

Release v6.4.0-BETA1#52220

Merged

Release v7.0.0-BETA1#52224

Merged