Using glob inside a phar does not work (it does not find anything). Using a DirectoryIterator on the other hand works with phars. This allows this command to compute the list of supported shells properly when used inside a phar.

Easy way to reproduce the bug: runcomposer completion unsupported (or more realisticallycomposer completion in a zsh shell as zsh is not a supported shell in symfony/console 5.4) with composer 2.5.5 and see that you get this error with an empty list of supported shells:

Detected shell "unsupported", which is not supported by Symfony shell completion (supported shells: "").

Fix the list of supported shells for completions in a phar

aabdc20

Using glob inside a phar does not work (it does not find anything).Using a DirectoryIterator on the other hand works with phars. Thisallows this command to compute the list of supported shells properlywhen used inside a phar.

stof requested a review fromchalasr as acode owner

April 21, 2023 18:07

carsonbot added Status: Needs Review Bug labels

Apr 21, 2023

carsonbot added this to the5.4 milestone

Apr 21, 2023

fabpot approved these changes

Apr 22, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Apr 22, 2023

Copy link

Member

fabpot commentedApr 22, 2023

Thank you@stof.

fabpot merged commit7589ff6 intosymfony:5.4

Apr 22, 2023

This was referencedApr 28, 2023

Release v5.4.23#50187

Merged

Release v6.2.10#50189

Merged

stof deleted the supported_shells_phar branch

May 11, 2023 13:58

Copy link

guvra commentedMay 17, 2023•
edited
Loading

FYI this introduced a regression on our side because the folder "Resources" is now mandatory (which was not the case before), so our compiled phar file didn't work anymore because we only included php files in it.

Easily fixable on our side by forcing the phar compiler to include these completion files though.

Copy link

MemberAuthor

stof commentedMay 17, 2023

Well, I would say that working with modified source code of the component is not really covered by our BC policy.
Also, the whole command would break if you don't include these completion files (executing the command will read those files to generate things).

Copy link

guvra commentedMay 17, 2023•
edited
Loading

Well, I would say that working with modified source code of the component is not really covered by our BC policy.

Yes I understand that, it's why i said that it's easily fixable on our side 👍

Also, the whole command would break if you don't include these completion files (executing the command will read those files to generate things).

Actually, when the Resources folder does not exist, the new code logic breaks any command that uses the symfony/console package, not just the command "DumpCompletionCommand" where the code logic was changed.

It's because the logic is contained in the methodconfigure, which is called for all commands defined in the application.