NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Console] Fix the usage of the zsh completion through the fpath discovery#50110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.2fromstof:fix_zsh_global_completion

Apr 22, 2023

Merged

[Console] Fix the usage of the zsh completion through the fpath discovery#50110

fabpot merged 1 commit intosymfony:6.2fromstof:fix_zsh_global_completion

Apr 22, 2023

Conversation

Copy link

Member

stof commentedApr 21, 2023

Q	A
Branch?	6.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	n/a
License	MIT
Doc PR	n/a

Zsh completion files registered through the fpath discovery mecanism have 2 requirements:

the file name must have a_ prefix
the file must start with a#compdef comment describing the registration for that file.

The file can then either execute the completion logic directly or callcompdef to register a function for completion. Keeping the second approach allows to use the same generated script for the global use case than for a sourced configuration script.

Fix the usage of the zsh completion through the fpath discovery

764e845

Zsh completion files registered through the fpath discovery mecanismhave 2 requirements:- the file name must have a `_` prefix- the file must start with a `#compdef` comment describing the  registration for that file.The file can then either execute the completion logic directly or call`compdef` to register a function for completion. Keeping the secondapproach allows to use the same generated script for the global use casethan for a sourced configuration script.