Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Do not ignore tagsname attribute when it does not define their name#50088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@MatTheCat
Copy link
Contributor

@MatTheCatMatTheCat commentedApr 21, 2023•
edited
Loading

QA
Branch?6.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#50081
LicenseMIT
Doc PRN/A

Tagsname attribute is ignored using XML if the tag name is its node content. That means<tag name="name_attribute">tag_name</tag> will return atag_name tag without any attribute.

This seems to be a regression from#36586.

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@MatTheCatMatTheCat changed the base branch from6.3 to6.2April 21, 2023 10:56
@MatTheCatMatTheCat marked this pull request as ready for reviewApril 21, 2023 10:57
@carsonbotcarsonbot added this to the6.2 milestoneApr 21, 2023
@MatTheCatMatTheCat changed the title[DependencyInjection] XML tagsname attribute ignored if the tag’s name is its node content[DependencyInjection] Do not ignore tagsname attribute when it does not define their nameApr 21, 2023
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedApr 21, 2023•
edited
Loading

Thanks; Can you add a test case please?

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nvm, there are test cases already :)

MatTheCat reacted with rocket emoji
@PhilETaylor
Copy link
Contributor

I have taken these proposed changes tosrc/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php and applied them, manually, in my live project that identified this issue originally,

Then, after a cache:clear, this problem has been resolved. So I confirm this PR fixes my original issue, in the original app that was complaining.

Thanks@MatTheCat - please consider signing up to GitHub Sponsors :)

@MatTheCat
Copy link
ContributorAuthor

Thanks for testing on a real project@PhilETaylor! Will look at this sponsorship thing 👀

@nicolas-grekas
Copy link
Member

Thank you@MatTheCat.

@nicolas-grekasnicolas-grekas merged commit6f77fa0 intosymfony:6.2Apr 21, 2023
@MatTheCatMatTheCat deleted the xml-tag-name-attribute branchApril 21, 2023 15:13
@fabpotfabpot mentioned this pull requestApr 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[6.3] non-existent resolver Symfony\Bridge\Doctrine\ArgumentResolver\EntityValueResolver

4 participants

@MatTheCat@carsonbot@nicolas-grekas@PhilETaylor
[8]ページ先頭
©2009-2025 Movatter.jp