Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] Fix support of Enum toConstraintValidator::formatValue#50017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromPhoneixS:ticket_50000
Apr 19, 2023

Conversation

@PhoneixS
Copy link
Contributor

@PhoneixSPhoneixS commentedApr 14, 2023
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#50000
LicenseMIT

I have added a simple check in theformatValue to see if the object is an enum and in that case, return the name of the enum instead of the "object" string.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@PhoneixSPhoneixS changed the base branch from6.3 to6.2April 14, 2023 11:39
@PhoneixS
Copy link
ContributorAuthor

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.2". Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Sorry, first time making a PR. I think it's changed now.

@stof
Copy link
Member

I'm wondering whether this should be done only when theOBJECT_AS_STRING flag is passed

@welcoMatticwelcoMattic changed the titleTicket 50000[Validator] Add support of Enum toConstraintValidator::formatValueApr 14, 2023
@PhoneixS
Copy link
ContributorAuthor

I have changed so enums are treated more like objects, if there isn't an OBJECT_TO_STRING flag they are displayed as "enum"; if the flag is present it returns the enum name.

I have also added both test cases (with or without the flag).

@PhoneixS
Copy link
ContributorAuthor

Tests passed but failed because of unrelatedError: KO src/Symfony/Component/HttpClient.

@nicolas-grekasnicolas-grekas changed the title[Validator] Add support of Enum toConstraintValidator::formatValue[Validator] Fix support of Enum toConstraintValidator::formatValueApr 19, 2023
@nicolas-grekasnicolas-grekas modified the milestones:6.3,5.4Apr 19, 2023
@nicolas-grekas
Copy link
Member

Thank you@PhoneixS.

@nicolas-grekasnicolas-grekas merged commit831e0ca intosymfony:5.4Apr 19, 2023
@PhoneixS
Copy link
ContributorAuthor

You’re welcome. It's always nice to return a little bit to a great project.

@PhoneixSPhoneixS deleted the ticket_50000 branchApril 19, 2023 07:47
This was referencedApr 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasr

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

Make ConstraintValidator->formatValue aware of enums

5 participants

@PhoneixS@carsonbot@stof@nicolas-grekas@welcoMattic

[8]ページ先頭

©2009-2025 Movatter.jp