Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] Fix support of Enum toConstraintValidator::formatValue#50017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedApr 14, 2023
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedApr 14, 2023
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.2". Cheers! Carsonbot |
PhoneixS commentedApr 14, 2023
Sorry, first time making a PR. I think it's changed now. |
stof commentedApr 14, 2023
I'm wondering whether this should be done only when the |
ConstraintValidator::formatValueUh oh!
There was an error while loading.Please reload this page.
PhoneixS commentedApr 17, 2023
I have changed so enums are treated more like objects, if there isn't an OBJECT_TO_STRING flag they are displayed as "enum"; if the flag is present it returns the enum name. I have also added both test cases (with or without the flag). |
PhoneixS commentedApr 17, 2023
Tests passed but failed because of unrelated |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ConstraintValidator::formatValueConstraintValidator::formatValuenicolas-grekas commentedApr 19, 2023
Thank you@PhoneixS. |
PhoneixS commentedApr 19, 2023
You’re welcome. It's always nice to return a little bit to a great project. |
Uh oh!
There was an error while loading.Please reload this page.
I have added a simple check in the
formatValueto see if the object is an enum and in that case, return the name of the enum instead of the "object" string.