Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Don't use eval() to render ESI/SSI#50013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
711c6ec to0464c44CompareUh oh!
There was an error while loading.Please reload this page.
952c300 to44269c3Comparefabpot commentedApr 17, 2023
Thank you@nicolas-grekas. |
fritzmg commentedMay 3, 2023
imho the issue is that it is not actually mandatory at all. Even the In any case, will this change also be back ported to Symfony 5.4? |
alexislefebvre commentedMay 4, 2023
@fritzmg I can't find the relevant page in the doc but backports are not applied in the Symfony ecosystem. This new way to render is a feature, it can't land on a previous release. |
fritzmg commentedMay 4, 2023
But it's a security issue that arbitrary code can be executed via the |
alexislefebvre commentedMay 4, 2023
Fair enough, does it require a CVE issue? 😬 |
nicolas-grekas commentedMay 4, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There is no security issue when one sets the secret as documented. |
fabpot commentedMay 4, 2023
Let's merge the fix in 5.4 and 6.2 as well. |
nicolas-grekas commentedMay 4, 2023
See#50238 |
…rekas)This PR was merged into the 5.4 branch.Discussion----------[HttpKernel] Don't use eval() to render ESI/SSI| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Because this might be an important security hardening, this PR is a backport of#50013 for 5.4.Commits-------ea449ca [HttpKernel] Don't use eval() to render ESI/SSI
Yes, this would not be needed if people were able to use a real
kernel.secret. But apparently, many fail.And it looks like we can do something about it, so let's makes this impossible to exploit :)