NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpClient][Messenger] add`PingWebhookMessage` and`PingWebhookMessageHandler`#49815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.4fromkbond:messenger-ping-webhook

Jul 30, 2023

Merged

[HttpClient][Messenger] add`PingWebhookMessage` and`PingWebhookMessageHandler`#49815

fabpot merged 1 commit intosymfony:6.4fromkbond:messenger-ping-webhook

Jul 30, 2023

Conversation

Copy link

Member

kbond commentedMar 25, 2023•
edited
Loading

Q	A
Branch?	6.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	n/a
License	MIT
Doc PR	todo

With symfony/scheduler, it could be useful to ping some kind of uptime monitoring service likeohdearapp.

Usage

useSymfony\Component\HttpClient\Messenger\PingWebhookMessage;$bus->dispatch(newPingWebhookMessage('GET','https://example.com'));// simple ping, throws HttpExceptionInterface on 3xx/4xx/5xx$bus->dispatch(newPingWebhookMessage('GET','https://example.com', throw:false));// ping, but does not throw HttpExceptionInterface on 3xx/4xx/5xx$bus->dispatch(newPingWebhookMessage('GET','https://example.com', ['headers' => ['X-FOO =>'bar'],// any HttpClientInterface options]));

TODO:

wire up
tests

carsonbot added Status: Needs Review Feature HttpClient Messenger RFCRFC = Request For Comments (proposals about features that you want to be discussed) labels

Mar 25, 2023

carsonbot added this to the6.3 milestone

Mar 25, 2023

carsonbot changed the title~~[HttpClient][Messenger][RFC] addPingWebhook andPingWebhookHandler~~[HttpClient][Messenger] addPingWebhook andPingWebhookHandler

Mar 25, 2023

Copy link

MemberAuthor

kbond commentedMar 25, 2023

Perhaps this would make more sense in the Webhook component? I wasn't sure if this would be in the same scope.

kbond force-pushed themessenger-ping-webhook branch from3d34fdd to12e3f2eCompare

March 27, 2023 15:56

kbond removed the RFCRFC = Request For Comments (proposals about features that you want to be discussed) label

Mar 27, 2023

kbond mentioned this pull request

Mar 27, 2023

[Messenger][Process] addRunProcessMessage andRunProcessMessageHandler#49813

Merged

2 tasks

welcoMattic approved these changes

Mar 30, 2023

View reviewed changes

Copy link

Member

welcoMattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think HttpClient is the good place for this 👍

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 30, 2023

Copy link

Member

fabpot commentedApr 10, 2023

The main idea here is to make the ping retry-able, isn't it?

Copy link

MemberAuthor

kbond commentedApr 10, 2023

The main idea here is to make the ping retry-able, isn't it?

You mean the logic for catching/throwing exceptions? The main idea was to know if a ping failed.

ro0NL reviewed

Apr 10, 2023

View reviewed changes

src/Symfony/Component/HttpClient/Messenger/PingWebhook.phpShow resolvedHide resolved

Copy link

Contributor

ro0NL commentedApr 10, 2023

all messages are already retry-ablehttps://symfony.com/doc/current/messenger.html#retries-failures

Copy link

MemberAuthor

kbond commentedApr 10, 2023

all messages are already retry-ablehttps://symfony.com/doc/current/messenger.html#retries-failures

The scheduler transport does not support retries.

nicolas-grekas modified the milestones:6.3,6.4

May 23, 2023

nicolas-grekas reviewed

Jun 9, 2023

View reviewed changes

src/Symfony/Component/HttpClient/composer.json OutdatedShow resolvedHide resolved

nicolas-grekas reviewed

Jun 9, 2023

View reviewed changes

src/Symfony/Component/HttpClient/CHANGELOG.md OutdatedShow resolvedHide resolved

nicolas-grekas approved these changes

Jun 9, 2023

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM after minor changes. Thanks for the PR.

Copy link

Member

nicolas-grekas commentedJun 9, 2023

Please improve the PR description a bit so that it's easier to start the doc. 🙏

Copy link

Member

nicolas-grekas commentedJun 28, 2023

(rebase needed + comments pending)

Copy link

MemberAuthor

kbond commentedJun 28, 2023

Yep, this is on my list!

kbond force-pushed themessenger-ping-webhook branch from12e3f2e toc6a4885Compare

July 28, 2023 12:00

Copy link

MemberAuthor

kbond commentedJul 28, 2023•
edited
Loading

Comments addressed, I think this is ready.

kbond commented

Jul 28, 2023

View reviewed changes

src/Symfony/Component/HttpClient/Messenger/PingWebhook.php OutdatedShow resolvedHide resolved

kbond changed the title~~[HttpClient][Messenger] addPingWebhook andPingWebhookHandler~~[HttpClient][Messenger] addPingWebhookMessage andPingWebhookMessageHandler

Jul 28, 2023

kbond force-pushed themessenger-ping-webhook branch from8629503 to3fc4175Compare

July 28, 2023 13:46

nicolas-grekas approved these changes

Jul 28, 2023

View reviewed changes

src/Symfony/Component/HttpClient/Messenger/PingWebhookMessage.phpShow resolvedHide resolved