By default,CsvEncoder decoding process explodes the headers automatically based on the. character to generate nested arrays, the separation character being configurable based on our needs. For instance:

username,birth.day,birth.month,birth.yeardeuchnord,9,6,1993

Would result in the following PHP array:

["username" =>"deuchnord","birth" => ["day" =>9,"month => 6,"year" =>1993    ]]

This is a very nice feature, but in some cases, we prefer to skip the generation of those nested arrays.
This PR provides a way to disable it by simply setting the already existentCsvEncoder::KEY_SEPARATOR_KEY option tofalse, so the same CSV above now results to:

["username" =>"deuchnord","birth.day" =>9,"birth.month => 6,"birth.year" =>1993]

[Serializer] CsvEncoder: allow the nested array parsing to be disabled

750ccc8

Deuchnord requested a review fromdunglas as acode owner

March 15, 2023 15:54

carsonbot added Status: Needs Review Feature Serializer labels

Mar 15, 2023

carsonbot added this to the6.3 milestone

Mar 15, 2023

mtarld requested changes

Mar 21, 2023

View reviewed changes

src/Symfony/Component/Serializer/Encoder/CsvEncoder.phpShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Mar 21, 2023

Update CsvEncoderContextBuilder

5701128

mtarld requested changes

Mar 27, 2023

View reviewed changes

src/Symfony/Component/Serializer/Tests/Context/Encoder/CsvEncoderContextBuilderTest.phpShow resolvedHide resolved

Deuchnord added2 commits

March 27, 2023 11:24

fix@mtarld's review

fbf5fff

Revert "fix@mtarld's review" (misunderstood the request, discussed i…

2b6191e

…n private, we keep as is)This reverts commitfbf5fff.

Deuchnord mentioned this pull request

Mar 27, 2023

[Serializer]false value forcsv_key_separatorsymfony/symfony-docs#18127

Open

Copy link

Member

dunglas commentedMay 3, 2023

I'm 👍 for the feature, but what about encoding? You should updateCsvEncoder::flatten() to take the new allowed value into account.

Copy link

Member

dunglas commentedMay 3, 2023

Also, usingfalse as a magic value will remove the ability to choose the character to use as a separator. What about introducing a newcsv_flatten option instead?