When using Annotations, annotations are cached atAnnotationLoader level.
Which is cleared when entities are changed. So the dev experience is optimal.

[ClassMetadataFactory.php](vendor/symfony/serializer/Mapping/Factory/ClassMetadataFactory.php") on line 51:[Symfony\Component\Serializer\Mapping\Loader\LoaderChain](vendor/symfony/serializer/Mapping/Loader/LoaderChain.php&line=28#line28) {#543 ▼  -loaders: array:1 [▼    0 => [Symfony\Component\Serializer\Mapping\Loader\AnnotationLoader](vendor/symfony/serializer/Mapping/Loader/AnnotationLoader.php&line=33#line33) {#544 ▼      -reader: [Doctrine\Common\Annotations\PsrCachedReader](vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/PsrCachedReader.php&line=22#line22) {#262 ▼        -delegate: [Doctrine\Common\Annotations\AnnotationReader](vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationReader.php&line=20#line20) {#263 ▶}        -cache: [Symfony\Component\Cache\Adapter\PhpArrayAdapter](vendor/symfony/cache/Adapter/PhpArrayAdapter.php&line=32#line32) {#277 ▶}        -debug: true        -loadedAnnotations: array:14 [▶]        -loadedFilemtimes: array:4 [▶]      }    }  ]}

When using yaml files, there is no cache at the loader level so I added in the past the same cache as for the prod env, as the metadata are effectively cleared when using only yaml config files.

#35109

The regression introduced by my patch is for people that do not use mapping files but use annotations.

#41961

But now, we are in the opposite situation: no cache for people using mapping files but not annotations.

On a current project it means loading 83 yaml files for each dev requests. It's not good at all.

A simple local fix is to add that in a dev services files.

serializer.mapping.cache_class_metadata_factory:class:'Symfony\Component\Serializer\Mapping\Factory\CacheClassMetadataFactory'decorates:'serializer.mapping.class_metadata_factory'arguments:['@serializer.mapping.cache_class_metadata_factory.inner', '@serializer.mapping.cache.symfony']

A solution in Symfony could be:
1/ only yaml/xml mapping files (enable_annotations: false) : cache like prod => that what I did in this PR, as it fixes the current perf regressions on my different projects. There is no cache on yaml/xml file as soon as annotation is enabled (which is the default)
2/ add a cache at reader level for yaml/xml loader
3/ add a cache cleaner at metadata level when annotation are enabled

carsonbot added Status: Needs Review Bug FrameworkBundle labels

Mar 13, 2023

carsonbot added this to the5.4 milestone

Mar 13, 2023

nicolas-grekas approved these changes

Mar 14, 2023

View reviewed changes

Copy link

Member

nicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This patch works for me as a fix for the regression in 5.4

This means the serializer cache is not auto-invalidated when using yaml/xml. That was the case before, and is an acceptable tradeoff given the perf drop of parsing all files in every requests (in dev).

For 6.3 or up, we could add some auto-invalidation mechanism based on resource checkers, like we do for the container. That'd mean allowing loaders to declare their resources and the cache metadata factory to use those resources to trigger a prune on the pool when needed.

If you're OK with that, can you please open an issue so that we keep track of the need?

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 14, 2023

Copy link

ContributorAuthor

bastnic commentedMar 14, 2023

This means the serializer cache is not auto-invalidated when using yaml/xml. That was the case before, and is an acceptable tradeoff given the perf drop of parsing all files in every requests (in dev).

No no, it is!