It would be very nice to have an even shorter syntax when the factory is a static function of the current class.

@weaverryanproposed

#[Factory('create', ['$foo' =>'foo'])]class FactoryAttributeService{

The attribute could also be on the factory function (we will have to deal with duplicate).

class FactoryAttributeService{    #[Factory(['$foo' =>'foo'])]publicstaticfunction create(string$foo):static

Thanks for the feedback@GromNaN! I implemented the first idea, but for the second one, I'm not sure.

I mean, this is indeed a great idea, but it seems it needs a lot of rework insrc/Symfony/Component/DependencyInjection/Compiler/RegisterAutoconfigureAttributesPass.php. The pass loops through class attributes which makes it more complex to deal with the#[Factory] attribute on methods.

But maybe my approach is not the right one and there's something I don't see?

Do we need this$bind argument ? Can't we rely on autowiring on the factory signature ?

I don't know if it's a necessity, but being able to configure the specific bindings of the factory directly in the attribute seems to me a good idea, because it allows to have all the information "centralized in the same place" in some way. What do you think?

I am not sure what is the goal here, I could see two:

• Discover services based on attributes, extending theresource: mechanism so it also works for factories.
• Provide additional information for services that are already being declared somewhere.

I am most interested in the first point.
For that, it would be most natural to have the attribute on a static method, and use the return type as the service id (unless a custom id is provided).
When doing this, I would name the attribute classService, notFactory, because the fact it is a factory is already obvious.
A class can contain more than one factory, each returning a different service.

class C {  #[Service]staticfunctioncreateA():A {..}  #[Service]staticfunctioncreateB():B {..}}

To avoid duplicates, the attribute can have a custom id, or a suffix that will be appended to the class name.

class C {  #[Service]staticfunctioncreateA():A {..}  #[Service(id:'a.other')]staticfunction createOtherA(): A {..}  #[Service]staticfunctioncreateB(): B {..}  #[Service(suffix:'.other')]staticfunctioncreateOtherB(): B {..}}

The#[Service] attribute could also be added on class level to explicitly register a class as a service.
I think right now this is not needed becauseresource: already registers all the classes. But perhaps there could be a different mode where this does not happen, and where only classes with#[Service] attribute are registered as services.

Thank you for your feedback@nicolas-grekas! I completely reworked the PR. It now allows aconstructor option on Autoconfigure. Also, this PR makes availableconstructor in PHP-DSL, YAML and XML.

When usingconstructor,factory cannot be used for obvious reasons.

@donquixote I think it would worth it to discuss this in an issue to gather feedback, as this PR's initial goal changed a bit 😄

That's rebased 👍 !

Thank you@alexandre-daubois.

I'm late to the game so feel free to ignore this comment.

Theconstructor property name is confusing as it points to the existing (and in this case wrong) OOP concept.
It also rises the question "How the services are instantiated if this property is not set - without the constructor?!"

staticFactoryMethod is the name of this instantiation concept.
I agree it's too mouthful for the property name but it points a developer in the correct direction.