Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Messenger] Addbury_on_reject option to Beanstalkd bridge#49652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
d27f62e to3243a9fComparebury_on_reject option to Beanstalkd bridgepriority andbury_on_reject options to Beanstalkd bridgepriority andbury_on_reject options to Beanstalkd bridgebury_on_reject option andBeanstalkdPriorityStamp to Beanstalkd bridge17fbade toee0db6aComparespideyfusion commentedJun 27, 2023
@X-Coder264 Could you please give this a glance since you originally worked on this transport implementation? |
X-Coder264 approved these changesJun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@spideyfusion The implementation looks good to me 👍
235b83f to669a8bfComparec6ec2c9 to64e02ecComparerebased ✅ |
f933998 to7987d87Comparea340de0 toc66a791Compare6a9a57c to9197b0bComparebury_on_reject option andBeanstalkdPriorityStamp to Beanstalkd bridgebury_on_reject option to Beanstalkd bridgeb706a44 to4ca177eComparefabpot added a commit that referenced this pull requestJan 5, 2025
…d bridge (HypeMC)This PR was merged into the 7.3 branch.Discussion----------[Messenger] Add `BeanstalkdPriorityStamp` to Beanstalkd bridge| Q | A| ------------- | ---| Branch? | 7.3| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues | -| License | MITExtracted from#49652 as the original PR was trying to do two separate things in one.Beanstalkd has the ability to configure the priority at which messages are reserved. This can now be set using the `BeanstalkdPriorityStamp`:```php$this->bus->dispatch(new SomeMessage('some data'), [ new BeanstalkdPriorityStamp(0),]);```Commits-------9926d59 [Messenger] Add BeanstalkdPriorityStamp to Beanstalkd bridge
Uh oh!
There was an error while loading.Please reload this page.
2824fcb tobc7dc5dComparefabpot approved these changesJan 27, 2025
Thank you@HypeMC. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Contains#59273.This PR adds two improvements to the Beanstalkd bridge:Beanstalkd has the concept of "buried" jobs, which is a way of denoting that something has gone wrong while the consumer was processing the job. This PR adds a
bury_on_rejectoption to bury rejected messages instead of deleting them, which is the current behavior. Since Symfony messenger's retry mechanism sends a new message for each retry and rejects the old one, it would create multiple buried jobs for each failed one. To avoid this issue aSentForRetryStampwas added to identify whether a failed message was sent for retry or not. As long as the retry mechanism keeps sending a new message, the old one will be deleted. Once it finishes, the final rejected message will be buried.Extracted to[Messenger] Add
BeanstalkdPriorityStampto Beanstalkd bridge #59273