Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ErrorHandler] [ErrorHander] Display exception properties in the HTML error page#49620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.3fromlyrixx:error-handler-exception
Mar 13, 2023

Conversation

lyrixx
Copy link
Member

@lyrixxlyrixx commentedMar 6, 2023•
edited
Loading

QA
Branch?6.3
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#49613
LicenseMIT
Doc PR

image

Code to reproduce
class MyExceptionextends \Exception{publicfunction__construct()    {parent ::__construct('some_message',0,newMyException2());    }publicstring$myMessage ='some_message';publicstring$myCode ='some_code';privatestring$privateStuff ='private_stuff';}class MyException2extends \Exception{privatestring$anotherPrivateStuff ='another_private_stuff';}

tucksaun, welcoMattic, Koc, and andrew-demb reacted with heart emoji
@lyrixxlyrixxforce-pushed theerror-handler-exception branch 2 times, most recently from918dac3 to078eef1CompareMarch 6, 2023 18:19
@WebMamba
Copy link
Contributor

What do you think about adding a new tab? And not be overwelled by too much information on the page load, but we can still access those informations easily.

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM as is, thanks for this improvement!

@lyrixx
Copy link
MemberAuthor

What do you think about adding a new tab?

I think it does not deserves it, and it's really tied to exceptions.

Copy link
Member

@welcoMatticwelcoMattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@lyrixx 👍

@fabpotfabpotforce-pushed theerror-handler-exception branch from078eef1 tob041d06CompareMarch 13, 2023 19:20
@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commitb0054f6 intosymfony:6.3Mar 13, 2023
@lyrixxlyrixx deleted the error-handler-exception branchMarch 13, 2023 21:00
@carsonbotcarsonbot changed the title[ErrorHander] Display exception properties in the HTML error page[ErrorHandler] [ErrorHander] Display exception properties in the HTML error pageMar 19, 2023
nicolas-grekas added a commit that referenced this pull requestMar 20, 2023
…and fix serializing FlattenException (nicolas-grekas)This PR was merged into the 6.3 branch.Discussion----------[ErrorHandler] Rewrite logic to dump exception properties and fix serializing FlattenException| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -The implementation in#49620 was flawed. This fixes it./cc `@lyrixx` FYICommits-------b5fbe18 [ErrorHandler] Rewrite logic to dump exception properties and fix serializing FlattenException
@fabpotfabpot mentioned this pull requestMay 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@welcoMatticwelcoMatticwelcoMattic approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

[ErrorHandler] Display more information about the current exception
7 participants
@lyrixx@WebMamba@fabpot@welcoMattic@yceruto@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp