Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[OptionsResolver] addignoreUndefined() method to allow skip not interesting options#49608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@kshtompel
Copy link

@kshtompelkshtompel commentedMar 6, 2023•
edited by GromNaN
Loading

QA
Branch?6.3
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#45370
LicenseMIT
Doc PRNOT ADDED

Allow to ignore not defined options to allow skip not interesting options when working with big set of shared configuration or just not to describe all the options provided by third party provider

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR, here are some minor comments.

@carsonbotcarsonbot changed the title- add ignoreUndefined() method to allow skip not interesting options[OptionsResolver] - add ignoreUndefined() method to allow skip not interesting optionsMar 9, 2023
@nicolas-grekasnicolas-grekas changed the title[OptionsResolver] - add ignoreUndefined() method to allow skip not interesting options[OptionsResolver] add ignoreUndefined() method to allow skip not interesting optionsMar 9, 2023
@nicolas-grekas
Copy link
Member

Please add a changelog entry indeed.

@OskarStark
Copy link
Contributor

It looks like your committer email is not associated with your Github account.

@kshtompel
Copy link
Author

Do I need recreate PR with new email configured or can leave it as is and commit changes with update email associated with the account

@kshtompel
Copy link
Author

@nicolas-grekas
Please advise where to put CHANGELOG update.
PR is made for version 6.3
but I see only 6.2 CHANGELOG file latest

@kshtompel
Copy link
Author

please advise how to change changelog file for the new feature

@yceruto
Copy link
Member

@kshtompel you can update the changelog in this filesrc/Symfony/Component/OptionsResolver/CHANGELOG.md

kshtompel reacted with thumbs up emoji

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR! It's almost ready for me. I've left you some minor changes.

@kshtompel
Copy link
Author

Added CHANGELOG note for version 6.2

@OskarStarkOskarStark changed the title[OptionsResolver] add ignoreUndefined() method to allow skip not interesting options[OptionsResolver] addignoreUndefined() method to allow skip not interesting optionsMar 26, 2023
@kshtompel
Copy link
Author

any updates so far?

@kshtompel
Copy link
Author

@nicolas-grekas
@yceruto
do i need change something?

@kshtompel
Copy link
Author

@yceruto something else here?

yceruto reacted with eyes emoji

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One move left and LGTM. Thank you!

@nicolas-grekasnicolas-grekasforce-pushed thefeature/45370-option-resolver-improve branch fromc485514 to21cd852CompareMay 2, 2023 16:27
@fabpot
Copy link
Member

Thank you@kshtompel.

nicolas-grekas added a commit that referenced this pull requestMay 12, 2023
This PR was merged into the 6.3 branch.Discussion----------[OptionsResolver] Fixed changelog| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -#49608Commits-------61279d4 Fixed changelog
@kshtompel
Copy link
Author

kshtompel commentedMay 16, 2023•
edited
Loading

@yceruto
I didn't change method definition in the CHANGELOG.md to OptionsResolver::setIgnoreUndefined()
it is still has OptionsResolver::ignoreUndefined()

6.3

  • Add OptionsResolver::ignoreUndefined() to ignore not defined options while resolving

Do I need create another PR to make this changes??

@yceruto
Copy link
Member

Don't worry, I already updated it here#50305

kshtompel reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@GromNaNGromNaNGromNaN approved these changes

@OskarStarkOskarStarkOskarStark left review comments

@ycerutoycerutoyceruto approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

Allow extra options in OptionsResolver

7 participants

@kshtompel@carsonbot@nicolas-grekas@OskarStark@yceruto@fabpot@GromNaN
[8]ページ先頭
©2009-2025 Movatter.jp