Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyInfo] Fix phpDocExtractor nullable array value type#49557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
carsonbot commentedFeb 28, 2023
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedFeb 28, 2023
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas approved these changesApr 17, 2023
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(I rebased the PR)
Member
fabpot commentedMay 5, 2023
Thank you@MudrakIvan. |
Merged
reviewtypo3org pushed a commit to TYPO3/typo3 that referenced this pull requestMay 28, 2023
Handling of collections without a dedicated type has changed in`symfony/property-info` with v6.2.11, [1] seems to be the offensivecommit.This should be backward compatible, as only string|int makesense for array keys and therefore is the same for array-likeobject annotation syntax.We raise the version constraint for `symfony/property-info`package to a slightly higher patchlevel version to ensureconsistent behaviour. This is done for shipped version andthe core development, therefore the raises are also addedto the corresponding extension composer.json files.Used command(s):> composer require --no-update \ -d typo3/sysext/extbase \ "symfony/property-info":"^6.2.11"> composer require \ "symfony/property-info":"^6.2.11"[1]symfony/symfony#49557Resolves: #100927Releases: main, 12.4Change-Id: I1465206414cd7e596d0852ed4288c5013db23c2dReviewed-on:https://review.typo3.org/c/Packages/TYPO3.CMS/+/79151Tested-by: core-ci <typo3@b13.com>Reviewed-by: Stefan Bürk <stefan@buerk.tech>Tested-by: Stefan Bürk <stefan@buerk.tech>Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
TYPO3IncTeam pushed a commit to TYPO3-CMS/extbase that referenced this pull requestMay 28, 2023
Handling of collections without a dedicated type has changed in`symfony/property-info` with v6.2.11, [1] seems to be the offensivecommit.This should be backward compatible, as only string|int makesense for array keys and therefore is the same for array-likeobject annotation syntax.We raise the version constraint for `symfony/property-info`package to a slightly higher patchlevel version to ensureconsistent behaviour. This is done for shipped version andthe core development, therefore the raises are also addedto the corresponding extension composer.json files.Used command(s):> composer require --no-update \ -d typo3/sysext/extbase \ "symfony/property-info":"^6.2.11"> composer require \ "symfony/property-info":"^6.2.11"[1]symfony/symfony#49557Resolves: #100927Releases: main, 12.4Change-Id: I1465206414cd7e596d0852ed4288c5013db23c2dReviewed-on:https://review.typo3.org/c/Packages/TYPO3.CMS/+/79151Tested-by: core-ci <typo3@b13.com>Reviewed-by: Stefan Bürk <stefan@buerk.tech>Tested-by: Stefan Bürk <stefan@buerk.tech>Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
reviewtypo3org pushed a commit to TYPO3/typo3 that referenced this pull requestMay 28, 2023
Handling of collections without a dedicated type has changed in`symfony/property-info` with v6.2.11, [1] seems to be the offensivecommit.This should be backward compatible, as only string|int makesense for array keys and therefore is the same for array-likeobject annotation syntax.We raise the version constraint for `symfony/property-info`package to a slightly higher patchlevel version to ensureconsistent behaviour. This is done for shipped version andthe core development, therefore the raises are also addedto the corresponding extension composer.json files.Used command(s):> composer require --no-update \ -d typo3/sysext/extbase \ "symfony/property-info":"^6.2.11"> composer require \ "symfony/property-info":"^6.2.11"[1]symfony/symfony#49557Resolves: #100927Releases: main, 12.4Change-Id: I1465206414cd7e596d0852ed4288c5013db23c2dReviewed-on:https://review.typo3.org/c/Packages/TYPO3.CMS/+/79152Tested-by: Stefan Bürk <stefan@buerk.tech>Reviewed-by: Stefan Bürk <stefan@buerk.tech>Tested-by: core-ci <typo3@b13.com>
TYPO3IncTeam pushed a commit to TYPO3-CMS/extbase that referenced this pull requestMay 28, 2023
Handling of collections without a dedicated type has changed in`symfony/property-info` with v6.2.11, [1] seems to be the offensivecommit.This should be backward compatible, as only string|int makesense for array keys and therefore is the same for array-likeobject annotation syntax.We raise the version constraint for `symfony/property-info`package to a slightly higher patchlevel version to ensureconsistent behaviour. This is done for shipped version andthe core development, therefore the raises are also addedto the corresponding extension composer.json files.Used command(s):> composer require --no-update \ -d typo3/sysext/extbase \ "symfony/property-info":"^6.2.11"> composer require \ "symfony/property-info":"^6.2.11"[1]symfony/symfony#49557Resolves: #100927Releases: main, 12.4Change-Id: I1465206414cd7e596d0852ed4288c5013db23c2dReviewed-on:https://review.typo3.org/c/Packages/TYPO3.CMS/+/79152Tested-by: Stefan Bürk <stefan@buerk.tech>Reviewed-by: Stefan Bürk <stefan@buerk.tech>Tested-by: core-ci <typo3@b13.com>
1 task
1 task
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Bug fix for nullable array value types + for multiple array key/value types.
Two existing tests changed:
Added new tests: