Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove unused private methods#49517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alamirault
Copy link
Contributor

QA
Branch?6.3
Bug fix?no
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

I searched all unused private methods in codebase and found these

$this->assertFlatViewWithlabelTranslationParameters($view);
}

privatefunctionassertScalarListWithChoiceValues(ChoiceListInterface$list)
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM except the trait

@alamiraultalamirault requested review fromnicolas-grekas and removed request forxabbuh andycerutoFebruary 23, 2023 20:51
@nicolas-grekasnicolas-grekasforce-pushed thefeature/remove-unused-private-methods branch from04525d3 to53322dcCompareFebruary 23, 2023 20:52
@nicolas-grekas
Copy link
Member

Thank you@alamirault.

@nicolas-grekasnicolas-grekas merged commit005faa6 intosymfony:6.3Feb 23, 2023
@alamiraultalamirault deleted the feature/remove-unused-private-methods branchFebruary 23, 2023 20:55
nicolas-grekas added a commit that referenced this pull requestSep 20, 2023
…w route to a collection (bram123)This PR was squashed before being merged into the 6.3 branch.Discussion----------[Routing] Fix routing collection defaults when adding a new route to a collection| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | ~| License       | MIT| Doc PR        | ~In our current Symfony project we use PHP routing files, and use routing collections that are setup before adding routes.Before upgrading to Symfony 6.3 this meant we could add an attribute to the collection, add X routes and they would all have this routing attribute (be it stateless / methods / defaults). After upgrading to S6.3 this no longer works.PR#49517 removed the createRoute method from the CollectionConfigurator, because it was thought to be unused, but this method was used when adding a new Route to a RouteCollection. Without the method, the createRoute method of the LocalizedRouteTrait was used.This means that when setting up a route collection before adding routes, the new routes no longer get the collection settings.Added a new unittest to prevent this from happening again. For now only added to the PhpFileLoaderTest, I don't know if this is also possible for XML/YML routing config to also add a test in those LoaderTests.Commits-------bfdd16e [Routing] Fix routing collection defaults when adding a new route to a collection
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

3 participants

@alamirault@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp