Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Remove unused private methods#49517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove unused private methods#49517
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $this->assertFlatViewWithlabelTranslationParameters($view); | ||
| } | ||
| privatefunctionassertScalarListWithChoiceValues(ChoiceListInterface$list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Was not removed when legacy tests were removed
31eb498#diff-18cef2a172697b433048f25490e0ccf5bec0b85c48b16040fb9fa3cd6bcfb4c9
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM except the trait
Uh oh!
There was an error while loading.Please reload this page.
04525d3 to53322dcComparenicolas-grekas commentedFeb 23, 2023
Thank you@alamirault. |
…w route to a collection (bram123)This PR was squashed before being merged into the 6.3 branch.Discussion----------[Routing] Fix routing collection defaults when adding a new route to a collection| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | ~| License | MIT| Doc PR | ~In our current Symfony project we use PHP routing files, and use routing collections that are setup before adding routes.Before upgrading to Symfony 6.3 this meant we could add an attribute to the collection, add X routes and they would all have this routing attribute (be it stateless / methods / defaults). After upgrading to S6.3 this no longer works.PR#49517 removed the createRoute method from the CollectionConfigurator, because it was thought to be unused, but this method was used when adding a new Route to a RouteCollection. Without the method, the createRoute method of the LocalizedRouteTrait was used.This means that when setting up a route collection before adding routes, the new routes no longer get the collection settings.Added a new unittest to prevent this from happening again. For now only added to the PhpFileLoaderTest, I don't know if this is also possible for XML/YML routing config to also add a test in those LoaderTests.Commits-------bfdd16e [Routing] Fix routing collection defaults when adding a new route to a collection
I searched all unused private methods in codebase and found these