Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow] display label with new lines + colours properly when rendering a PUML dump#49516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromalexislefebvre:5.4-fix-style-of-label-containing-new-lines-in-puml-dumpFeb 24, 2023
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a3edf88 toc363a64Comparesrc/Symfony/Component/Workflow/Tests/fixtures/puml/arrow/complex-state-machine-marking.pumlShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
c363a64 tod0da385Comparelyrixx approved these changesFeb 23, 2023
Uh oh!
There was an error while loading.Please reload this page.
d0da385 to361dce2CompareMember
nicolas-grekas commentedFeb 24, 2023
Thank you@alexislefebvre. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
In#49272 I removed the new lines instead of formatting them properly.
The PUML format accept new lines in labels of transitions as long as the source file uses actual
\nstrings instead of line returns (likePHP_EOL).I propose a novel approach that will handle new lines with or without colours.
Compare these outputs from plantuml.com, inputs are based on thefixtures from Symfony:
After#49272
New lines are ignored
(source)
Correct output from this PR
With this patch → the second line is Grey and no tag is visible
(source)
Why close and open
<font>tags?The output is broken if we use
\nwithout taking into account the<font>tags → there is a second line but it is black and</font>is visible(source)