Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[FrameworkBundle][HttpClient] Refactor http_client decoration strategy#49513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
fancyweb commentedFeb 23, 2023
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | #49302 (comment) |
| License | MIT |
| Doc PR | - |
src/Symfony/Component/HttpClient/DependencyInjection/HttpClientPass.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Rebase unlocked after#49302 |
52e5f75 to237f7b6Compare237f7b6 to11e2164Comparenicolas-grekas approved these changesFeb 24, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| @@ -2413,7 +2406,7 @@ private function registerHttpClientConfiguration(array $config, ContainerBuilder | |||
| ->register($name.'.uri_template', UriTemplateHttpClient::class) | |||
| ->setDecoratedService($name, null, 7) // Between TraceableHttpClient (5) and RetryableHttpClient (10) | |||
| ->setArguments([ | |||
| new Reference('.inner'), | |||
| new Reference($name.'.uri_template.inner'), | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
let's be consistent with the rest of the file
| ->set('http_client', HttpClientInterface::class) | ||
| ->factory('current') | ||
| ->args([[service('http_client.transport')]]) |
Member
nicolas-grekasFeb 24, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Here is the master trick of this PR :)
This creates what I'd call a "tagged alias".
Thank you@fancyweb. |
nicolas-grekas added a commit that referenced this pull requestFeb 24, 2023
… used as service factory (nicolas-grekas)This PR was merged into the 6.3 branch.Discussion----------[DependencyInjection] Optimize out "current()" when it's used as service factory| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Sometimes, we need to use the "identity function" as a service factory.One example is#49513, where we use that to create a "tagged alias".In PHP, the identity function is `current([$foo])`.Let's optimize out such calls.Commits-------834a550 [DependencyInjection] Optimize out "current()" when it's used as service factory
fabpot added a commit that referenced this pull requestJan 2, 2025
… (HypeMC)This PR was merged into the 6.4 branch.Discussion----------[HttpClient] Fix `reset()` not called on decorated clients| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITThis was broken in#49513 for the main HTTP client and, as far as I can tell, never worked for scoped clients. The problem is that some decorator clients, like the `ThrottlingHttpClient`, have their own `reset()` method, which never gets called when using the `services_resetter` service. Scoped clients don't decorate the main one but instead use it as a dependency.Commits-------8f5f98a [HttpClient] Fix reset not called on decorated clients
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.