Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Change FormTypeValidatorExtension construct signature#49502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
alamirault wants to merge4 commits intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromalamirault:feature/change-form-type-validator-extension-signature

Conversation

alamirault
Copy link
Contributor

QA
Branch?6.3
Bug fix?no
New feature?no
Deprecations?yes
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

$legacyErrorMessages is required inFormTypeValidatorExtension construct but it is not used anymore in class. This PR deprecate passing this argument.

@alamiraultalamiraultforce-pushed thefeature/change-form-type-validator-extension-signature branch fromc74bc36 to43f04bbCompareFebruary 22, 2023 21:13
@carsonbotcarsonbot changed the titleChange FormTypeValidatorExtension construct signature[Form] Change FormTypeValidatorExtension construct signatureFeb 22, 2023
@alamiraultalamiraultforce-pushed thefeature/change-form-type-validator-extension-signature branch from2c616dd toa9e9b85CompareFebruary 23, 2023 20:48
@alamiraultalamirault requested review fromnicolas-grekas and removed request forxabbuh andycerutoFebruary 23, 2023 20:48
alamiraultand others added2 commitsMarch 5, 2023 11:29
Co-authored-by: Christian Flothmann <christian.flothmann@gmail.com>
@alamirault
Copy link
ContributorAuthor

Thanks@xabbuh and@HypeMC for the review.

I added TypeError when args types are not ok

@alamiraultalamirault requested review fromHypeMC andxabbuh and removed request fornicolas-grekas andHypeMCMarch 5, 2023 10:50
/**
* @group legacy
*/
public function testLegacyWithBadFormRendererType()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is not the legacy signature, but the new one though, as you don't pass the boolean.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You are right. But when type hint will be set in 7.0. Args checking will be drop and tests must also be dropped.

I can keep@group legacy and only removelegacy in function name ?

@nicolas-grekasnicolas-grekas removed this from the6.3 milestoneMay 23, 2023
@nicolas-grekasnicolas-grekas added this to the6.4 milestoneMay 23, 2023
@nicolas-grekasnicolas-grekas modified the milestones:6.4,7.1Nov 15, 2023
@xabbuhxabbuh modified the milestones:7.1,7.2May 15, 2024
@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@HypeMCHypeMCHypeMC left review comments

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

7 participants
@alamirault@nicolas-grekas@stof@xabbuh@HypeMC@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp