Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Add tests for#[TaggedIterator] &#[TaggedLocator] on controller arguments#49500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@HypeMC
Copy link
Member

@HypeMCHypeMC commentedFeb 22, 2023•
edited
Loading

QA
Branch?6.3
Bug fix?no
New feature?no
Deprecations?no
TicketsFix#49083
LicenseMIT
Doc PR-

I think this doesn't qualify as a bug fix, but an improvement. If I'm wrong please let me know.

#49628 fixed the issue, this PR only adds tests now.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks.
Can you please let me know if#[Autowire(new TaggedLocator(...))] (or#[Autowire(new ServiceLocatorArgument())] I don't remember) works?

@HypeMCHypeMCforce-pushed thetaggediterator-and-taggedlocator-as-controller-argument branch from187fa79 to09f38cfCompareFebruary 22, 2023 19:33
@HypeMC
Copy link
MemberAuthor

Thanks. Can you please let me know if#[Autowire(new TaggedLocator(...))] (or#[Autowire(new ServiceLocatorArgument())] I don't remember) works?

@nicolas-grekas No, neither work. As far as I can tell, the#[Autowire] attribute is not designed to work like that.

@HypeMC
Copy link
MemberAuthor

HypeMC commentedFeb 22, 2023•
edited
Loading

Funny thing, this does seem to work:

#[Autowire([newServiceLocatorArgument(newTaggedIteratorArgument(...)),newTaggedIteratorArgument(...)])]

In this case, the argument is an array with a service locator and an iterator.

@HypeMCHypeMCforce-pushed thetaggediterator-and-taggedlocator-as-controller-argument branch from09f38cf to226cb98CompareFebruary 23, 2023 09:15
@nicolas-grekas
Copy link
Member

Can you please try#49628? It might have fixed the issue. If not, the PR will still need to be updated to account for the changes in#49628.

@HypeMCHypeMCforce-pushed thetaggediterator-and-taggedlocator-as-controller-argument branch from226cb98 to8900199CompareMarch 9, 2023 22:14
@HypeMCHypeMC changed the title[DependencyInjection][HttpKernel] Add support for#[TaggedIterator] &#[TaggedLocator] with controller arguments[DependencyInjection] Add tests for#[TaggedIterator] &#[TaggedLocator] on controller argumentsMar 9, 2023
@HypeMC
Copy link
MemberAuthor

Can you please try#49628? It might have fixed the issue. If not, the PR will still need to be updated to account for the changes in#49628.

@nicolas-grekas Yep,#49628 fixed the problem. I've removed all my changes except the test cases as this particular functionality isn't covered anywhere.

nicolas-grekas reacted with hooray emoji

@HypeMCHypeMCforce-pushed thetaggediterator-and-taggedlocator-as-controller-argument branch from8900199 to121e072CompareMarch 9, 2023 22:26
@carsonbotcarsonbot changed the title[DependencyInjection] Add tests for#[TaggedIterator] &#[TaggedLocator] on controller arguments[DependencyInjection][HttpKernel] Add tests for#[TaggedIterator] &#[TaggedLocator] on controller argumentsMar 10, 2023
@carsonbotcarsonbot changed the title[DependencyInjection][HttpKernel] Add tests for#[TaggedIterator] &#[TaggedLocator] on controller arguments[HttpKernel] Add tests for#[TaggedIterator] &#[TaggedLocator] on controller argumentsMar 10, 2023
@nicolas-grekas
Copy link
Member

Thank you@HypeMC.

@nicolas-grekasnicolas-grekas merged commit844df3e intosymfony:6.3Mar 10, 2023
@HypeMCHypeMC deleted the taggediterator-and-taggedlocator-as-controller-argument branchMarch 10, 2023 10:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

TaggedLocator/TaggedIterator attributes does not work in controller argument

3 participants

@HypeMC@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp