Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Add support for Exclude attribute#49492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.3fromlyrixx:exclude
Feb 23, 2023

Conversation

@lyrixx
Copy link
Member

QA
Branch?6.3
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#46643
LicenseMIT
Doc PR

meyerbaptiste reacted with hooray emojiruudk reacted with heart emoji
@lyrixxlyrixxforce-pushed theexclude branch 3 times, most recently from3a93c5d to66af40fCompareFebruary 22, 2023 12:04
}

/**
* @dataProvider provideRegisterClassesWithExcludeAttributeTests

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

let's replace the provider with@testWith [true] [false]

welcoMattic reacted with thumbs up emoji
@derrabus
Copy link
Member

FTR: This feature has been discussed and rejected once:#46655

@alanpoulain
Copy link
Contributor

Why not just adding the attribute suggested in#47196?

#[Attribute(Attribute::TARGET_CLASS | Attribute::TARGET_METHOD | Attribute::TARGET_FUNCTION | Attribute::IS_REPEATABLE)]finalclass Excludeextends When{publicfunction__construct()    {parent::__construct('never');    }}

@lyrixx
Copy link
MemberAuthor

@derrabus I know but I think many people need it

@alanpoulain because this is a hack 😊

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't have strong enough arguments to reject a second time so LGTM :)

chalasr reacted with thumbs up emojiruudk, derrabus, lyrixx, and alexandre-le-borgne reacted with heart emoji
@nicolas-grekas
Copy link
Member

Thank you@lyrixx.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

[DependencyInjection] Add attribute #[Exclude]

5 participants

@lyrixx@derrabus@alanpoulain@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp