NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mailer] Update Infobip API transport#49488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.2fromndousson:update_infobip_api_transport

Feb 22, 2023

Merged

[Mailer] Update Infobip API transport#49488

nicolas-grekas merged 1 commit intosymfony:6.2fromndousson:update_infobip_api_transport

Feb 22, 2023

Conversation

Copy link

Contributor

ndousson commentedFeb 22, 2023•
edited
Loading

Q	A
Branch?	6.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	N/A
License	MIT
Doc PR	N/A

📍 Context

Infobip send an email to their customers that do not use the latest API release:V3

They inform that everything is backward compatible and can be easily upgraded without any changes.

🛠️ Changes

This PR change the version used from the V2 to the V3.

Copy link

carsonbot commentedFeb 22, 2023

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

ndousson force-pushed theupdate_infobip_api_transport branch from8e21fda to0b1757aCompare

February 22, 2023 09:57

ndousson marked this pull request as ready for review

February 22, 2023 09:58

carsonbot added Status: Needs Review Feature labels

Feb 22, 2023

carsonbot added this to the6.2 milestone

Feb 22, 2023

Copy link

carsonbot commentedFeb 22, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

nicolas-grekas added the Mailer label

Feb 22, 2023

carsonbot changed the title~~Update Infobip API transport~~[Mailer] Update Infobip API transport

Feb 22, 2023

nicolas-grekas reviewed

Feb 22, 2023

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you please split this PR in two?
One for 6.2, that just bump the number in the default endpoint. This will be a bugfix and doesn't need any change to the CHANGELOG file

Another one for 6.3 to propose the new attributes. Note that no other bridges support similar features and we've been super careful not to create bridges with too custom behaviors. This might be discussed on that new PR.

Copy link

ContributorAuthor

ndousson commentedFeb 22, 2023

Thanks Nicolas for your feedback 🙏

I'll split this PR as you suggest.

I know that other bridges didn't work like Infobip but I hope we'll find a good way to be able to use reporting behavior 👍
We'll see in the PR for 6.3