NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Contracts] Fix setting $container before calling parent::setContainer in ServiceSubscriberTrait#49441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromedsrzf:service-subscriber-trait-fix

Feb 21, 2023

Merged

[Contracts] Fix setting $container before calling parent::setContainer in ServiceSubscriberTrait#49441

nicolas-grekas merged 1 commit intosymfony:5.4fromedsrzf:service-subscriber-trait-fix

Feb 21, 2023

Conversation

Copy link

edsrzf commentedFeb 18, 2023

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#49382
License	MIT

This changes thesetContainer method ofServiceSubscriberTrait so that it callsparent::setContainer first, before updating$this->container. This is so that the parent method can work correctly if it relies on the old container value.

This is particularly relevant forAbstractController, since it returns the old container value. When used withServiceSubscriberTrait, it returned thenew container rather than the old one. This, in turn, caused incorrect behavior in framework bundle'sControllerResolver, as described in#49382.

carsonbot added Status: Needs Review Bug labels

Feb 18, 2023

carsonbot added this to the5.4 milestone

Feb 18, 2023

Copy link

carsonbot commentedFeb 18, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

edsrzf force-pushed theservice-subscriber-trait-fix branch from8b7fcb2 to1c2ab9dCompare

February 18, 2023 23:53

nicolas-grekas approved these changes

Feb 20, 2023

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense to me.

src/Symfony/Contracts/Tests/Service/ServiceSubscriberTraitTest.phpShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Feb 20, 2023

nicolas-grekas added the Contracts label

Feb 20, 2023

carsonbot changed the title~~Fix ServiceSubscriberTrait usage with AbstractController~~[Contracts] Fix ServiceSubscriberTrait usage with AbstractController

Feb 20, 2023

nicolas-grekas changed the title~~[Contracts] Fix ServiceSubscriberTrait usage with AbstractController~~[Contracts] Fix setting $container before calling parent::setContainer in ServiceSubscriberTrait

Feb 21, 2023