Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache][Messenger] fixed CallbackInterface support in async expiration handler#49422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Cache][Messenger] fixed CallbackInterface support in async expiration handler#49422
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $pool =$message->findPool($this->reverseContainer); | ||
| $callback =$message->findCallback($this->reverseContainer); | ||
| $value =$callback($item); | ||
| $save =true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't this implement the handling of this$save flag ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My guess is at this point this is not needed since it was specifically asked to recalculate the cache item asynchronously.
There could be some use cases that I miss though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It does look like I am doing something wrong here. But I am also guessing if handling$save will make things worse for someone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nicolas-grekas can you give your opinion on this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My guess is at this point this is not needed since it was specifically asked to recalculate the cache item asynchronously.
Correct!
nicolas-grekas commentedFeb 21, 2023
Thank you@AdamKatzDev. |
Adds support for CallbackInterface in EarlyExpirationHandler and thus fixes async cache recomputing for callables that implement CallbackInterface. Earlier similar errors were fixed in#31879.