NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[MonologBridge] FirePHPHandler::onKernelResponse throws PHP 8.1 deprecation when no user agent is set#49405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromjuagarc4:ticket_49392

Feb 21, 2023

Merged

[MonologBridge] FirePHPHandler::onKernelResponse throws PHP 8.1 deprecation when no user agent is set#49405

nicolas-grekas merged 1 commit intosymfony:5.4fromjuagarc4:ticket_49392

Feb 21, 2023

Conversation

Copy link

Contributor

juagarc4 commentedFeb 16, 2023

Q	A
Branch?	5.4
Bug fix?	yes/no
New feature? no
Deprecations? no
Tickets	Fix#49392
License	MIT

Add casting to the second parameter to pass always the right type.

PHPstan before:

Line FirePHPHandler.php

27 Property Symfony\Bridge\Monolog\Handler\FirePHPHandler::$headers has no type specified.
37 Method Symfony\Bridge\Monolog\Handler\FirePHPHandler::onKernelResponse() has no return type specified.
44 Parameter#2 $subject of function preg_match expects string, string|null given.
68 If condition is always true.

PHPstan after:

Line FirePHPHandler.php

carsonbot added Status: Needs Review Bug MonologBridge labels

Feb 16, 2023

carsonbot added this to the5.4 milestone

Feb 16, 2023

Copy link

carsonbot commentedFeb 16, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot