NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[BC Break] Make data providers for abstract test cases static#49368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 2 commits intosymfony:5.4fromOskarStark:static-data-providers-test

Feb 17, 2023

Merged

[BC Break] Make data providers for abstract test cases static#49368

nicolas-grekas merged 2 commits intosymfony:5.4fromOskarStark:static-data-providers-test

Feb 17, 2023

Conversation

Copy link

Contributor

OskarStark commentedFeb 14, 2023•
edited by nicolas-grekas
Loading

Q	A
Branch?	5.4
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	Refs#48668
License	MIT
Doc PR	-

Follows#48668 (comment)

Todos

Bump min version incomposer.json Notifier@OskarStark
Bump min version incomposer.json Translation@OskarStark
Bump min version incomposer.json Mailer@OskarStark
Bump min version incomposer.json Security@OskarStark -nothing todo
document BC break in CHANGELOG files Notifier@OskarStark
document BC break in CHANGELOG files Translation@OskarStark
document BC break in CHANGELOG files Mailer@OskarStark
document BC break in CHANGELOG files Security@OskarStark
document BC break in UPGRADE files Notifier@OskarStark
document BC break in UPGRADE files Translation@OskarStark
document BC break in UPGRADE files Mailer@OskarStark
document BC break in UPGRADE files Security@OskarStark
remove $this in static methods@alexandre-daubois
make tests green

OskarStark added the BC Break label

Feb 14, 2023

OskarStark requested a review fromnicolas-grekas

February 14, 2023 10:00

OskarStark requested review fromchalasr andwouterj ascode owners

February 14, 2023 10:00

carsonbot added the Status: Needs Review label

Feb 14, 2023

carsonbot added this to the5.4 milestone

Feb 14, 2023

OskarStark changed the title~~Static data providers test~~[BC Break] Make data providers for abstract test cases static

Feb 14, 2023

OskarStark commented

Feb 14, 2023

View reviewed changes

src/Symfony/Component/Notifier/Test/TransportFactoryTestCase.phpShow resolvedHide resolved

nicolas-grekas reviewed

Feb 14, 2023

View reviewed changes

tools/rector.php OutdatedShow resolvedHide resolved

nicolas-grekas reviewed

Feb 14, 2023

View reviewed changes

src/Symfony/Component/Translation/Test/ProviderTestCase.phpShow resolvedHide resolved

OskarStark force-pushed thestatic-data-providers-test branch from6d6daca to0074829Compare

February 14, 2023 19:53

Copy link

ContributorAuthor

OskarStark commentedFeb 14, 2023

Rebased

alexandre-daubois mentioned this pull request

Feb 15, 2023

[Notifier] MakeTransportTestCase data providers static#49385

Merged

OskarStark force-pushed thestatic-data-providers-test branch 2 times, most recently from4de5115 toc233a27Compare

February 15, 2023 09:50

nicolas-grekas added a commit that referenced this pull request

Feb 15, 2023

bug#49385[Notifier] MakeTransportTestCasedata providers static …

a9c2bce

…(alexandre-daubois)This PR was merged into the 5.4 branch.Discussion----------[Notifier] Make `TransportTestCase` data providers static| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Part of#49368| License       | MIT| Doc PR        | -:information_source: Note: the `TransportTestCase::createTransport()` method also had to be passed to static.cc `@OskarStark`Commits-------6a9f1d0 [Notifier] Make `TransportTestCase` data providers static