Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add PHP types to private methods and functions#49348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Serializer/Mapping/ClassDiscriminatorFromClassMetadata.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This PR was merged into the 6.3 branch.Discussion----------Add many missing PHPdoc return types| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | yes| Tickets | Ref#47551, continues#49342| License | MIT| Doc PR | -This PR adds lots of ``@return`` PHPdoc that we missed in the 5.4 branch. These will produce new deprecation warnings, if applications override one of these methods. It will not break backwards compatibility.Adding these PHPdoc in 6.3 already allow the community to test all these annotations for 6 months in stable version, before committing to adding them as PHP types in 7.0. This way, I hope we patch out any wrong type.This PR is done using a slightly modified Psalter script, based on Psalm's type inference. See#49348 for the counter PR adding real PHP types to private, final or internal methods.Commits-------e23d8be Add missing PHPdoc return types
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
02325f2 to384c9a6Comparenicolas-grekas commentedFeb 13, 2023
Thank you@wouterj. |
…(fancyweb)This PR was merged into the 6.3 branch.Discussion----------[TwigBridge] Fix TwigDataCollector::getTime() return type| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Ref#49348It generates implicit incompatible float to int conversion deprecations.Commits-------29e2e13 [TwigBridge] Fix TwigDataCollector::getTime() return type
Uh oh!
There was an error while loading.Please reload this page.
This PR adds real PHP types to private, internal or final (excluding
@final) methods based on Psalm's type inference. Many more return types are missing still, but let's do them in other contributions.This change can result in BC breaks in multiple ways, so we should carefully review the changes:
@final, but not yet realfinal), we should instead add a PHPdoc return type (seeAdd many missing PHPdoc return types #49349)