NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpKernel] Fix setting the session on the main request when it's started by a subrequest#49265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:hk-session-main

Feb 13, 2023

Merged

[HttpKernel] Fix setting the session on the main request when it's started by a subrequest#49265

nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:hk-session-main

Feb 13, 2023

Conversation

Copy link

Member

nicolas-grekas commentedFeb 6, 2023•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

When a sub-request starts the session (eg when app.flashes is used in a template), the main request remains unaware of it and so doesSessionListener as a consequence. This prevents it from running itsonKernelResponse logic, leading to e.g. aSet-Cookie being sent on such pages even when a session is already active.