Should be good now@xabbuh

Search the codebase withabstract class .+Test extends I also find some more classes that probably need to be updated as well.

Since we're changing the names of a lot of classes anyway, shall we make the naming a bit more consitent? We haveAbstractSomethingTestCase,BaseSomethingTestCase,SomethingTestCase, …

I think,SomethingTestCase is the pattern that we use for our reusable test case classes already (WebTestCase,KernelTestCase, …). Would it make sense to use that pattern everywhere?

What about doing this on 6.3. We can continue using phpunit 9 for the time being on 5.4.

@xabbuh but aren't these classes in /Test/ which follows BC?

@derrabus open for the renaming of others agree

@nicolas-grekas we are doing the other PHPUnit stuff against 5.4, but how you like

I don't have a strong opinion, but I think we shouldn't do it on 5.4.

Let's go with 6.3 then 👍🏻🤓

Agreed, this is a feature according to ourpolicies:

The following changes are never accepted in a patch version:

• ...
• Support for newer major versions of Composer dependencies

Per se it's just a renaming of an internal class, so the policy does not match here from my POV.

The one why I thought it makes sense to use 5.4 is to avoid merge conflicts.

But as I said, ok let's go with 6.3

But what about the static data providers and the open PR from@xabbuh ?

Lets wait for

• [RemoveTestSuffixFromAbstractTestClassesRector] Add new rule (#132) rectorphp/rector-phpunit#141

Superseded by

• [PHPUnit 10] UseTestCase suffix for abstract tests in/Tests/ #49253

What about doing this on 6.3. We can continue using phpunit 9 for the time being on 5.4.

Late to the party here. 🙈

We can go for 6.3 for this change, but that means we need to silence the deprecation regarding those classes on 5.4. We should run the tests on the 5.4 branch with PHPUnit 9.6 because 9.5 likely won't receive fixes for PHP 8.3/8.4.

@derrabus makes sense. I've cherry-picked#49253 on 5.4 inaec2271

@OskarStark see#49419