Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Use PHPUnit 9.6 to run Symfony's test suite#49233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
derrabus commentedFeb 4, 2023
Comment on lines -13 to -14
| if (\PHP_VERSION_ID <70200) { | ||
| putenv('SYMFONY_PHPUNIT_VERSION=7.5'); |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was a leftover from Symfony 4 wasn't it?
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd keep this, the bridge is still declared as compatible with <7.2
MemberAuthor
derrabus commentedFeb 4, 2023
All right, the output gives us a couple of tasks to work on for PHPUnit 10. |
Member
xabbuh commentedFeb 4, 2023
👍 I would have expected a lot of messages about the deprecated |
Contributor
OskarStark commentedFeb 4, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It was fixed in Referenced PR in#49218 |
Member
xabbuh commentedFeb 4, 2023
Yeah, for that particular case which is a file that can be used by users of Symfony. But we make heavy use of |
Contributor
OskarStark commentedFeb 4, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ok... but why 🤷♂️ ... That will be a lot of work for the abstract test cases in |
OskarStark added a commit to OskarStark/symfony that referenced this pull requestFeb 4, 2023
Using `Test` suffix is deprecated since PHPUnit 10Spooted in*symfony#49233
Contributor
OskarStark commentedFeb 4, 2023
Oh no, we already named them |
OskarStark added a commit to OskarStark/symfony that referenced this pull requestFeb 4, 2023
Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony#49233
OskarStark added a commit to OskarStark/symfony that referenced this pull requestFeb 6, 2023
Replacessymfony#49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony#49233
nicolas-grekas added a commit that referenced this pull requestFeb 6, 2023
…NotAttribute()` (xabbuh)This PR was merged into the 5.4 branch.Discussion----------stop using `assertObjectHasAttribute()`/`assertObjectHasNotAttribute()`| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | related#49233| License | MIT| Doc PR |Commits-------442b43c stop using assertObjectHasAttribute()/assertObjectHasNotAttribute()
OskarStark added a commit to OskarStark/symfony that referenced this pull requestFeb 7, 2023
Replacessymfony#49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony#49233
nicolas-grekas added a commit that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refs#49233| License | MIT| Doc PR | n/aReplaces#49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*#49233Commits-------cb3db96 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
nicolas-grekas added a commit that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refs#49233| License | MIT| Doc PR | n/aReplaces#49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*#49233Commits-------cb3db96 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
symfony-splitter pushed a commit to symfony/console that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refssymfony/symfony#49233| License | MIT| Doc PR | n/aReplaces #49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony/symfony#49233Commits-------cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
symfony-splitter pushed a commit to symfony/security-core that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refssymfony/symfony#49233| License | MIT| Doc PR | n/aReplaces #49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony/symfony#49233Commits-------cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
symfony-splitter pushed a commit to symfony/security-bundle that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refssymfony/symfony#49233| License | MIT| Doc PR | n/aReplaces #49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony/symfony#49233Commits-------cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
symfony-splitter pushed a commit to symfony/property-access that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refssymfony/symfony#49233| License | MIT| Doc PR | n/aReplaces #49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony/symfony#49233Commits-------cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
symfony-splitter pushed a commit to symfony/twig-bridge that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refssymfony/symfony#49233| License | MIT| Doc PR | n/aReplaces #49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony/symfony#49233Commits-------cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
symfony-splitter pushed a commit to symfony/routing that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refssymfony/symfony#49233| License | MIT| Doc PR | n/aReplaces #49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony/symfony#49233Commits-------cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
symfony-splitter pushed a commit to symfony/serializer that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refssymfony/symfony#49233| License | MIT| Doc PR | n/aReplaces #49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony/symfony#49233Commits-------cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
symfony-splitter pushed a commit to symfony/translation that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refssymfony/symfony#49233| License | MIT| Doc PR | n/aReplaces #49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony/symfony#49233Commits-------cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
symfony-splitter pushed a commit to symfony/lock that referenced this pull requestFeb 7, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refssymfony/symfony#49233| License | MIT| Doc PR | n/aReplaces #49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony/symfony#49233Commits-------cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
MemberAuthor
derrabus commentedFeb 14, 2023
What's the fix for…
? Registering a custom error handler? 🤔 |
This was referencedFeb 14, 2023
nicolas-grekas added a commit that referenced this pull requestFeb 14, 2023
…Unit getMockClass() method (xabbuh)This PR was merged into the 5.4 branch.Discussion----------[WebProfilerBundle] replace usages of the deprecated PHPUnit getMockClass() method| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | related to#49233| License | MIT| Doc PR |Commits-------2f7c509 replace usages of the deprecated PHPUnit getMockClass() method
Member
xabbuh commentedFeb 14, 2023
I think it's easier:#49375 (I need to check all places though) |
nicolas-grekas added a commit that referenced this pull requestFeb 14, 2023
…certain strings (xabbuh)This PR was merged into the 5.4 branch.Discussion----------use proper methods to assert exception messages contain certain strings| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | related to#49233| License | MIT| Doc PR |Commits-------5b3e6a5 use proper methods to assert exception messages contain certain strings
ecbe5b7 to4237f77Compare493a9b9 toefd7cbbCompareMemberAuthor
derrabus commentedFeb 14, 2023
🟢 |
This was referencedFeb 14, 2023
nicolas-grekas added a commit that referenced this pull requestFeb 15, 2023
This PR was merged into the 6.2 branch.Discussion----------Fix PHPUnit 9.6 deprecations| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | Related to#49233| License | MIT| Doc PR | N/AThis PR fixes deprecations introduced by PHPUnit 9.6. We should merge this PR before merging up#49233.Commits-------a6896fa Fix PHPUnit 9.6 deprecations
src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
efd7cbb toe1ca0aaCompareMember
nicolas-grekas commentedFeb 15, 2023
Thank you@derrabus. |
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestJul 28, 2023
… `/Tests/` (OskarStark)This PR was merged into the 6.3 branch.Discussion----------[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Refssymfony/symfony#49233| License | MIT| Doc PR | n/aReplaces #49234Using `Test` suffix is deprecated since PHPUnit 10Spotted in*symfony/symfony#49233Commits-------cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's use PHPUnit 9.6 to run test test suite if we can.