Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] FixPasswordHasherListener to work with empty data#49208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
791d794 to6494370ComparePasswordHasherListener to work with empty datafabpot commentedFeb 4, 2023
Thank you@1ed. |
| $this->assertSame($user->getPassword(),$hashedPassword); | ||
| } | ||
| publicfunctiontestPasswordHashSuccessWitnEmptyData() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
testPasswordHashSuccessWitnEmptyData
should be:
testPasswordHashSuccessWithEmptyData
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good catch, but it's already fixed in the6.2 branch :) (seed88d5b3)
Uh oh!
There was an error while loading.Please reload this page.
This fixes the case when a new user is created by the form,
for example in a registration form. Before this the listener
thrown an exception, because when it tried to get the user
it was not available yet. With this the user resolved later
at the root form when empty data already ran. Other then that
the logic is the same just refactored a code a bit to make it
more readable.