NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[WebProfilerBundle] Remove obsolete elements and attributes#49205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.3fromjaviereguiluz:profiler_obsolete_html

Feb 4, 2023

Merged

[WebProfilerBundle] Remove obsolete elements and attributes#49205

fabpot merged 1 commit intosymfony:6.3fromjaviereguiluz:profiler_obsolete_html

Feb 4, 2023

Conversation

Copy link

Member

javiereguiluz commentedFeb 2, 2023

Q	A
Branch?	6.3
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

javiereguiluz added the WebProfilerBundle label

Feb 2, 2023

javiereguiluz added this to the6.3 milestone

Feb 2, 2023

carsonbot added the Status: Needs Review label

Feb 2, 2023

yceruto approved these changes

Feb 2, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Feb 2, 2023

stof approved these changes

Feb 2, 2023

View reviewed changes

OskarStark approved these changes

Feb 3, 2023

View reviewed changes

javiereguiluz mentioned this pull request

Feb 3, 2023

[WebProfilerBundle] Fix some minor HTML issues#49223

Closed

fabpot added a commit that referenced this pull request

Feb 4, 2023

bug#49223[WebProfilerBundle] Fix some minor HTML issues (javieregui…

00676bc

…luz)This PR was squashed before being merged into the 5.4 branch.Discussion----------[WebProfilerBundle] Fix some minor HTML issues| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -In#49205 we're fixing deprecations, so I chose 6.3 branch. Here we are fixing bugs related to invalid HTML contents, so that's why I chose 5.4 branch.The issue related to `<summary>` is that it only allows tags that can be included inside a `<p>`, but not `<p>` itself (verified withhttps://validator.w3.org/):<img width="502" alt="summary-p" src="https://user-images.githubusercontent.com/73419/216625646-73f7f73d-a315-43da-9d9a-44ce430c70e5.png">Commits-------31ce660 [WebProfilerBundle] Fix some minor HTML issues