Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Crawler] Fix regression where cdata nodes will return empty string#49195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@NanoSector
Copy link
Contributor

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

Fixes a regression caused by the fix to#48682 where<script> tags would return empty string on the innerContent call, where in 6.2 this did work.

Attached is a zipped PHPUnit test case used to verify the regression on 6.2 with a screenshot of its result.

CrawlerInnerTextTest.zip
image

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

I think@tgalopin has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekasnicolas-grekas modified the milestones:6.3,6.4May 23, 2023
@NanoSectorNanoSectorforce-pushed thebugfix/crawler-fix-backwards-compatibility-innertext branch 2 times, most recently from2c88cda to184a1d1CompareMay 25, 2023 17:32
@NanoSector
Copy link
ContributorAuthor

fabbot reports a code style issue regarding a comment for a parameter that is commented out - is this patch wanted, or necessary for my PR to pass?

@fabpotfabpot modified the milestones:6.4,6.3Aug 1, 2023
@fabpotfabpot changed the base branch from6.4 to6.3August 1, 2023 07:43
@fabpotfabpot requested a review fromxabbuh as acode ownerAugust 1, 2023 07:43
@fabpot
Copy link
Member

Thank you@NanoSector.

NanoSector reacted with thumbs up emoji

@fabpotfabpot merged commitfbb3f05 intosymfony:6.3Aug 1, 2023
@fabpotfabpot mentioned this pull requestAug 26, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

@lyrixxlyrixxAwaiting requested review from lyrixx

@dunglasdunglasAwaiting requested review from dunglas

@ycerutoycerutoAwaiting requested review from yceruto

@kbondkbondAwaiting requested review from kbond

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasr

@OskarStarkOskarStarkAwaiting requested review from OskarStark

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

4 participants

@NanoSector@carsonbot@fabpot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp