Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Improve exception message in UnwrappingDenormalizer#49186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromandersonamuller:patch-4
May 17, 2024
Merged

[Serializer] Improve exception message in UnwrappingDenormalizer#49186

fabpot merged 1 commit intosymfony:6.4fromandersonamuller:patch-4
May 17, 2024

Conversation

@andersonamuller
Copy link
Contributor

QA
Branch?6.3
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

The current code expects the path to be replaced in the message, but probably it was forgotten.

Copy link
Contributor

@alamiraultalamirault left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch !

I'm not sure, but I think it's considered as a bug and target must be 6.2 (was not on 5.4)

alexislefebvre reacted with thumbs up emoji
@alexislefebvre
Copy link
Contributor

It looks like this line wasn't tested so far.

If you have time, you can add a test that check this exception.

@nicolas-grekasnicolas-grekas modified the milestones:6.3,6.4May 23, 2023
@nicolas-grekasnicolas-grekas modified the milestones:6.4,7.1Nov 15, 2023
@xabbuhxabbuh modified the milestones:7.1,6.4May 15, 2024
@carsonbotcarsonbot changed the titleImprove exception message in UnwrappingDenormalizer[Serializer] Improve exception message in UnwrappingDenormalizerMay 15, 2024
@fabpotfabpot changed the base branch from7.1 to6.4May 17, 2024 09:01
@fabpot
Copy link
Member

Thank you@andersonamuller.

@fabpotfabpot merged commite4bd593 intosymfony:6.4May 17, 2024
@fabpotfabpot mentioned this pull requestMay 17, 2024
This was referencedJun 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@alamiraultalamiraultalamirault left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

7 participants

@andersonamuller@alexislefebvre@fabpot@xabbuh@alamirault@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp