NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[FrameworkBundle] Detect unused environment variables in .env#49161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

mw3e21a wants to merge7 commits intosymfony:7.4

base:7.4

Choose a base branch

frommw3e21a:detect-unused-env-vars

Open

[FrameworkBundle] Detect unused environment variables in .env#49161

mw3e21a wants to merge7 commits intosymfony:7.4frommw3e21a:detect-unused-env-vars

+68 −13

Conversation

Copy link

Contributor

mw3e21a commentedJan 30, 2023•
edited by GromNaN
Loading

Q	A
Branch?	6.3
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix#48552
License	MIT
Doc PR	symfony/symfony-docs#17833

Improvedbin/console debug:container --env-vars and the--env-var option to display the number of occurrences of each environment variable in the container. This allows you to identify unused variables from .env files.

Example usage:
php bin/console debug:container --env-vars

php bin/console debug:container --env-var=APP_SECRET

Detect unused environment variables in .env

f241ee7

carsonbot added Status: Needs Review Feature labels

Jan 30, 2023

carsonbot added this to the6.3 milestone

Jan 30, 2023

mw3e21a changed the title~~Detect unused environment variables in .env~~[FrameworkBundle] Detect unused environment variables in .env

Jan 30, 2023

GromNaN reviewed

Jan 30, 2023

View reviewed changes

Copy link

Member

GromNaN left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like this way of demonstrating usage of each variable.

Here is the output forsymfony/demo. We can see thatAPP_ENV is not used by the container (because it is used earlier).

$bin/console debug:container --env-varsSymfony Container Environment Variables======================================= ------------------- ------------------ ------------------------------------------------------- -------------  Name                Default value      Real value                                              Usage count ------------------- ------------------ ------------------------------------------------------- -------------  APP_ENV             n/a                "dev"                                                   0  APP_SECRET          n/a                "2ca64f8d83b9e89f5f19d672841d6bb8"                      8  DATABASE_URL        n/a                "sqlite:///%kernel.project_dir%/data/database.sqlite"   1  VAR_DUMPER_SERVER   "127.0.0.1:9912"   n/a                                                     3 ------------------- ------------------ ------------------------------------------------------- ------------- // Note real values might be different between web and CLI.