Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Intl] Generate all emoji short name returned by slack api#49147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.2fromadnen-chouibi:patch-3
Feb 6, 2023

Conversation

@adnen-chouibi
Copy link
Contributor

QA
Branch?6.2
Bug fix?yes
New feature?no
Deprecations?no
Ticketsno
LicenseMIT
Doc PRNA

I have been utilizing the slack-emoji helper to convert country codes to flag emojis. I propose to standardize all flags by using the format :flag-countryCode: for all flags, or maybe create another helper especially for flags. Additionally, I suggest incorporating all emojis returned in the 'short_names' array, rather than relying solely on the 'short_name' value. I have improved the file naming process by generating the file name in the builder, rather than in the 'saveRules' method.

@nicolas-grekas
Copy link
Member

Thanks, can you update the generated files in the same PR please?

@adnen-chouibi
Copy link
ContributorAuthor

I suggest building a new file flag-emoji.php, to convert country codes to flags. This new feature could enhance the Intl component by adding a convenient method, such as Countries::getFlag('GB'), which would return 🇬🇧.

@stof
Copy link
Member

@adnen-chouibi that feature does not depend on building a map. Seehttps://github.com/thekelvinliu/country-code-emoji for the JS implementation of such a feature, which relies only on the knowledge of how emoji flags are encoded.
This is not even a work for the symfony/intl component IMO.

@carsonbotcarsonbot changed the titleGenerate all emoji short name returned by slack api[Intl] Generate all emoji short name returned by slack apiFeb 6, 2023
@nicolas-grekas
Copy link
Member

Thank you@adnen-chouibi.

adnen-chouibi reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commitbd4c57f intosymfony:6.2Feb 6, 2023
@fabpotfabpot mentioned this pull requestFeb 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

4 participants

@adnen-chouibi@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp